Clean code.

This commit is contained in:
Lars Jung 2015-04-27 01:53:34 +02:00
parent ddf23d1ea5
commit fcaddbbd3b
4 changed files with 13 additions and 13 deletions

View file

@ -3,14 +3,13 @@ modulejs.define('ext/crumb', ['_', '$', 'core/event', 'core/location', 'core/res
var settings = _.extend({
enabled: false
}, allsettings.crumb);
var template = '<div id="crumbbar"/>';
var crumbTemplate =
'<a class="crumb">' +
'<img class="sep" src="' + resource.image('crumb') + '" alt=">"/>' +
'<span class="label"/>' +
'</a>';
var pageHintTemplate = '<img class="hint" src="' + resource.icon('folder-page') + '" alt="has index page"/>';
var $crumbbar = $(template).appendTo(topbar.$flowbar);
var $crumbbar;
function createHtml(item) {
@ -57,6 +56,8 @@ modulejs.define('ext/crumb', ['_', '$', 'core/event', 'core/location', 'core/res
return;
}
$crumbbar = $('<div id="crumbbar"/>').appendTo(topbar.$flowbar);
event.sub('location.changed', onLocationChanged);
}

View file

@ -6,17 +6,16 @@ modulejs.define('ext/download', ['_', '$', 'core/event', 'core/location', 'core/
packageName: 'package',
alwaysVisible: false
}, allsettings.download);
var downloadBtnTemplate =
var template =
'<div id="download" class="tool">' +
'<img src="' + resource.image('download') + '" alt="download"/>' +
'</div>';
var selectedItems = [];
var $download;
function onSelection(items) {
var $download = $('#download');
selectedItems = items.slice(0);
if (selectedItems.length) {
$download.show();
@ -55,12 +54,12 @@ modulejs.define('ext/download', ['_', '$', 'core/event', 'core/location', 'core/
return;
}
$(downloadBtnTemplate)
.on('click', onClick)
.appendTo('#toolbar');
$download = $(template)
.appendTo('#toolbar')
.on('click', onClick);
if (settings.alwaysVisible) {
$('#download').show();
$download.show();
}
event.sub('selection', onSelection);

View file

@ -24,11 +24,11 @@ modulejs.define('ext/peer5', ['_', '$', 'core/settings'], function (_, $, allset
// attach to file items, once the DOM is ready
$(function () {
$('body').on('click', '.item.file > a', function (e) {
$('body').on('click', '.item.file > a', function (ev) {
if (window.peer5) {
e.preventDefault();
var url = e.currentTarget.href;
ev.preventDefault();
var url = ev.currentTarget.href;
window.peer5.download(url);
return false;
}

View file

@ -12,7 +12,7 @@ html
body
div#report
a( href="index.html" ) h5ai #{pkg.version} test suite
a( href="index.html" ) h5ai #{pkg.version}
div.stats
div.progress
div#mocha-overlay