diff --git a/src/_h5ai/client/js/inc/ext/crumb.js b/src/_h5ai/client/js/inc/ext/crumb.js index 2892ce6a..06f04173 100644 --- a/src/_h5ai/client/js/inc/ext/crumb.js +++ b/src/_h5ai/client/js/inc/ext/crumb.js @@ -3,14 +3,13 @@ modulejs.define('ext/crumb', ['_', '$', 'core/event', 'core/location', 'core/res var settings = _.extend({ enabled: false }, allsettings.crumb); - var template = '
'; var crumbTemplate = '' + '>' + '' + ''; var pageHintTemplate = 'has index page'; - var $crumbbar = $(template).appendTo(topbar.$flowbar); + var $crumbbar; function createHtml(item) { @@ -57,6 +56,8 @@ modulejs.define('ext/crumb', ['_', '$', 'core/event', 'core/location', 'core/res return; } + $crumbbar = $('
').appendTo(topbar.$flowbar); + event.sub('location.changed', onLocationChanged); } diff --git a/src/_h5ai/client/js/inc/ext/download.js b/src/_h5ai/client/js/inc/ext/download.js index 6ce3b399..72bbca8b 100644 --- a/src/_h5ai/client/js/inc/ext/download.js +++ b/src/_h5ai/client/js/inc/ext/download.js @@ -6,17 +6,16 @@ modulejs.define('ext/download', ['_', '$', 'core/event', 'core/location', 'core/ packageName: 'package', alwaysVisible: false }, allsettings.download); - var downloadBtnTemplate = + var template = '
' + 'download' + '
'; var selectedItems = []; + var $download; function onSelection(items) { - var $download = $('#download'); - selectedItems = items.slice(0); if (selectedItems.length) { $download.show(); @@ -55,12 +54,12 @@ modulejs.define('ext/download', ['_', '$', 'core/event', 'core/location', 'core/ return; } - $(downloadBtnTemplate) - .on('click', onClick) - .appendTo('#toolbar'); + $download = $(template) + .appendTo('#toolbar') + .on('click', onClick); if (settings.alwaysVisible) { - $('#download').show(); + $download.show(); } event.sub('selection', onSelection); diff --git a/src/_h5ai/client/js/inc/ext/peer5.js b/src/_h5ai/client/js/inc/ext/peer5.js index c20f45ae..268ce04f 100644 --- a/src/_h5ai/client/js/inc/ext/peer5.js +++ b/src/_h5ai/client/js/inc/ext/peer5.js @@ -24,11 +24,11 @@ modulejs.define('ext/peer5', ['_', '$', 'core/settings'], function (_, $, allset // attach to file items, once the DOM is ready $(function () { - $('body').on('click', '.item.file > a', function (e) { + $('body').on('click', '.item.file > a', function (ev) { if (window.peer5) { - e.preventDefault(); - var url = e.currentTarget.href; + ev.preventDefault(); + var url = ev.currentTarget.href; window.peer5.download(url); return false; } diff --git a/test/index.html.jade b/test/index.html.jade index a90425ed..9de406bf 100644 --- a/test/index.html.jade +++ b/test/index.html.jade @@ -12,7 +12,7 @@ html body div#report - a( href="index.html" ) h5ai #{pkg.version} test suite + a( href="index.html" ) h5ai #{pkg.version} div.stats div.progress div#mocha-overlay