From 86595984a0e042743d17b53005524ee634726025 Mon Sep 17 00:00:00 2001 From: Nathan Thomas Date: Sun, 24 Dec 2023 11:22:49 -0800 Subject: [PATCH] Explanation of ISRC edge case --- streamrip/metadata/tagger.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/streamrip/metadata/tagger.py b/streamrip/metadata/tagger.py index 0bbafa1..aa9286d 100644 --- a/streamrip/metadata/tagger.py +++ b/streamrip/metadata/tagger.py @@ -158,6 +158,9 @@ class Container(Enum): elif k == "discnumber": text = [(meta.discnumber, meta.album.disctotal)] elif k == "isrc" and meta.isrc is not None: + # because ISRC is an mp4 freeform value (not supported natively) + # we have to pass in the actual bytes to mutagen + # See mutagen.MP4Tags.__render_freeform text = meta.isrc.encode("utf-8") else: text = self._attr_from_meta(meta, k)