[misc] fix Coverity warnings

* Also re-instate the _coverity.cmd script and try to fix AppVeyor Coverity uploads
This commit is contained in:
Pete Batard 2020-06-19 10:53:40 +01:00
parent 1e85b4dbf5
commit c8078b0119
No known key found for this signature in database
GPG key ID: 38E0CF5E69EDD671
7 changed files with 45 additions and 17 deletions

View file

@ -1270,7 +1270,7 @@ BOOL ToggleEsp(DWORD DriveIndex)
r = DeviceIoControl(hPhysical, IOCTL_DISK_SET_DRIVE_LAYOUT_EX, (BYTE*)DriveLayout, size, NULL, 0, &size, NULL);
if (!r) {
uprintf("Could not set drive layout: %s", WindowsErrorString());
return FALSE;
goto out;
}
RefreshDriveLayout(hPhysical);
if (CompareGUID(&DriveLayout->PartitionEntry[i].Gpt.PartitionType, &PARTITION_GENERIC_ESP)) {
@ -1279,7 +1279,7 @@ BOOL ToggleEsp(DWORD DriveIndex)
} else if (!IsDriveLetterInUse(*mount_point)) {
// We succesfully switched ESP to Basic Data -> Try to mount it
volume_name = GetLogicalName(DriveIndex, DriveLayout->PartitionEntry[i].StartingOffset.QuadPart, TRUE, FALSE);
MountVolume(mount_point, volume_name);
IGNORE_RETVAL(MountVolume(mount_point, volume_name));
free(volume_name);
}
ret = TRUE;