[net] drop direct hooking into wininet DLL and use delay-loading instead

* Now that we can delay-load DLLs for both MinGW and MSVC, we can remove the
  cumbersome direct DLL hooks into wininet.dll (which is vulnerable to side
  loading when not delay-loaded) and revert to using direct API calls instead.
* This reverts part of e1d864f755.
* Also attempt to silence a Coverity warning.
This commit is contained in:
Pete Batard 2022-04-12 13:35:41 +01:00
parent e7b66e7e4c
commit 3194a4dac4
No known key found for this signature in database
GPG key ID: 38E0CF5E69EDD671
9 changed files with 81 additions and 124 deletions

View file

@ -1580,7 +1580,7 @@ BOOL DumpFatDir(const char* path, int32_t cluster)
}
do {
// coverity[-taint_source]
// coverity[tainted_data_return]
dirpos.cluster = libfat_dumpdir(lf_fs, &dirpos, &diritem);
if (dirpos.cluster >= 0) {
name = wchar_to_utf8(diritem.name);