Add pylint checks

This commit is contained in:
Andre Basche 2023-07-12 19:36:32 +02:00
parent 2788a3ac91
commit b0e3b15ff0
16 changed files with 47 additions and 39 deletions

View file

@ -18,7 +18,7 @@ class HonParameter:
] = {}
self._set_attributes()
def _set_attributes(self):
def _set_attributes(self) -> None:
self._category = self._attributes.get("category", "")
self._typology = self._attributes.get("typology", "")
self._mandatory = self._attributes.get("mandatory", 0)
@ -61,7 +61,7 @@ class HonParameter:
return self._group
def add_trigger(
self, value: str, func: Callable[["HonRule"], None], data: "HonRule"
self, value: str, func: Callable[["HonRule"], None], data: "HonRule"
) -> None:
if self._value == value:
func(data)
@ -93,5 +93,5 @@ class HonParameter:
return result
def reset(self):
def reset(self) -> None:
self._set_attributes()

View file

@ -10,18 +10,18 @@ def clean_value(value: str | float) -> str:
class HonParameterEnum(HonParameter):
def __init__(self, key: str, attributes: Dict[str, Any], group: str) -> None:
super().__init__(key, attributes, group)
self._default = ""
self._value = ""
self._default: str | float = ""
self._value: str | float = ""
self._values: List[str] = []
self._set_attributes()
if self._default and clean_value(self._default.strip("[]")) not in self.values:
self._values.append(self._default)
def _set_attributes(self):
def _set_attributes(self) -> None:
super()._set_attributes()
self._default = self._attributes.get("defaultValue")
self._default = self._attributes.get("defaultValue", "")
self._value = self._default or "0"
self._values: List[str] = self._attributes.get("enumValues", [])
self._values = self._attributes.get("enumValues", [])
def __repr__(self) -> str:
return f"{self.__class__} (<{self.key}> {self.values})"

View file

@ -6,12 +6,12 @@ from pyhon.parameter.base import HonParameter
class HonParameterFixed(HonParameter):
def __init__(self, key: str, attributes: Dict[str, Any], group: str) -> None:
super().__init__(key, attributes, group)
self._value = None
self._value: str | float = ""
self._set_attributes()
def _set_attributes(self):
def _set_attributes(self) -> None:
super()._set_attributes()
self._value = self._attributes.get("fixedValue", None)
self._value = self._attributes.get("fixedValue", "")
def __repr__(self) -> str:
return f"{self.__class__} (<{self.key}> fixed)"

View file

@ -37,7 +37,7 @@ class HonParameterProgram(HonParameterEnum):
@values.setter
def values(self, values: List[str]) -> None:
return
raise ValueError("Cant set values {values}")
@property
def ids(self) -> Dict[int, str]:

View file

@ -14,13 +14,13 @@ class HonParameterRange(HonParameter):
self._value: float = 0
self._set_attributes()
def _set_attributes(self):
def _set_attributes(self) -> None:
super()._set_attributes()
self._min: float = str_to_float(self._attributes["minimumValue"])
self._max: float = str_to_float(self._attributes["maximumValue"])
self._step: float = str_to_float(self._attributes["incrementValue"])
self._default: float = str_to_float(self._attributes.get("defaultValue", self.min))
self._value: float = self._default
self._min = str_to_float(self._attributes["minimumValue"])
self._max = str_to_float(self._attributes["maximumValue"])
self._step = str_to_float(self._attributes["incrementValue"])
self._default = str_to_float(self._attributes.get("defaultValue", self.min))
self._value = self._default
def __repr__(self) -> str:
return f"{self.__class__} (<{self.key}> [{self.min} - {self.max}])"