From 248c144e7acd37fbea31e5d7e1cffa5fbd0e4196 Mon Sep 17 00:00:00 2001 From: edgd1er Date: Fri, 15 Apr 2022 22:47:09 +0200 Subject: [PATCH] client: request #51 add automatic discovery. changes after review. --- docker/docker-py3-kms-minimal/Dockerfile | 2 +- docker/docker-py3-kms/Dockerfile | 2 +- docs/Usage.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docker/docker-py3-kms-minimal/Dockerfile b/docker/docker-py3-kms-minimal/Dockerfile index 579e4ba..dc6b54b 100644 --- a/docker/docker-py3-kms-minimal/Dockerfile +++ b/docker/docker-py3-kms-minimal/Dockerfile @@ -14,7 +14,7 @@ ENV LOGFILE STDOUT ENV LOGSIZE "" COPY ./py-kms /home/py-kms -#hadolint ignore=DL3013,DL3018 + RUN apk add --no-cache --update \ bash \ git \ diff --git a/docker/docker-py3-kms/Dockerfile b/docker/docker-py3-kms/Dockerfile index 2a8689d..4075466 100644 --- a/docker/docker-py3-kms/Dockerfile +++ b/docker/docker-py3-kms/Dockerfile @@ -17,7 +17,7 @@ ENV LOGSIZE "" ENV TZ America/Chicago COPY py-kms /home/py-kms/ -#hadolint ignore=DL3013,DL3018 + RUN apk add --no-cache --update \ bash \ git \ diff --git a/docs/Usage.md b/docs/Usage.md index 2c26824..0a14598 100644 --- a/docs/Usage.md +++ b/docs/Usage.md @@ -143,7 +143,7 @@ user@host ~/path/to/folder/py-kms $ python3 pykms_Server.py -V DEBUG user@host ~/path/to/folder/py-kms $ python3 pykms_Client.py -V DEBUG ``` -If you wish to get KMS server from DNS server: (ie perform a DNS resolution on _vlmcs._tcp.domain.tld, if ever there are several answers, only the first one is selected.) +If you wish to get KMS server from DNS server: (ie perform a DNS resolution on _vlmcs._tcp.domain.tld, if ever there are several answers, only the first one is selected.). Althought that mode is supposed to be specific to devices connect to an Active Directory domain, setting a fully qualified name and a workgroup may help to use that automatic KMS discovery feature. ``` user@host ~/path/to/folder/py-kms $ python3 pykms_Client.py -V DEBUG -F STDOUT -D contoso.com user@host ~/path/to/folder/py-kms $ python3 pykms_Client.py -V DEBUG -F STDOUT -D contoso.com