mirrors/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2025-05-24 03:57:06 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
1579 commits 48 branches 50 tags 228 MiB
Commit graph

588 commits

Author SHA1 Message Date
Philip Molares
1942df0da0
AzureBackend: Add Azure MediaBackend 
Add @azure/storage-blob dependency
This is the relevant part of the official azure sdk.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-22 22:33:56 +01:00
Philip Molares
95b3c628ce
DBSchema: Add fileUrl to media_upload table 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-27 11:24:41 +01:00
Philip Molares
a00a093a14
ImgurBackend: Add Imgur MediaBackend 
Add node-fetch dependency.
This was chosen as other libs we use already use node-fetch.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-26 16:16:00 +01:00
Philip Molares
c64ca9c012
MediaUploadEntity: Add fileUrl 
Save the fileUrl, returned to the user on creation, in the DB.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-26 16:12:14 +01:00
David Mehren
3dd4bf1582
Refactor server version object into own interface 
This makes the type of getServerVersionFromPackageJson() way easier
to read.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-27 21:21:41 +01:00
David Mehren
5987e2ed7e
Refactor config utils to use functions instead of consts 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-27 17:45:44 +01:00
David Mehren
b128efebff
Enforce explicit function return types 
This re-enables the `@typescript-eslint/explicit-module-boundary-types`
check and also enables the
`@typescript-eslint/explicit-function-return-type` check.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-27 17:41:32 +01:00
David Mehren
05926c08d6
FilesystemBackend: Fix ESLint errors 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-26 12:24:35 +01:00
David Mehren
56d28188e7
NotesController: Fix ESLint errors 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-24 22:33:47 +01:00
David Mehren
dd424cbcee
MeController: Fix ESLint errors 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-24 22:33:29 +01:00
David Mehren
0344a8294e
ConsoleLoggerService: Fix ESLint errors 
We now use @types/cli-color to provide type information

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-24 20:39:25 +01:00
David Mehren
f79492fe63
NoteEntity: Fix ESLint errors 
We now use @types/shortid to provide type information

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-24 21:10:24 +01:00
David Mehren
71e2f06bbb
Fix ESLint errors in main.ts 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-24 21:08:08 +01:00
David Mehren
cc1ca69bc1
Fix various ESLint errors in services 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-24 22:35:06 +01:00
David Mehren
21403ba606
Fix various ESLint errors in unit tests 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-24 20:20:04 +01:00
David Mehren
208ff1d039
Fix various ESLint errors in configs 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-24 20:29:39 +01:00
David Mehren
616f963b8e
HistoryService: toHistoryEntryDto does not need to be async 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-24 21:19:48 +01:00
David Mehren
bfa5f0dfc6
NotesService: toNotePermissionsDto does not need to be async 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-24 21:17:05 +01:00
David Mehren
def4ef145e
AuthService: randomString does not need to by async 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-23 22:16:27 +01:00
David Mehren
fed3a12779
Add explicit Request type 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-23 21:48:37 +01:00
David Mehren
a5d922b5f8
Use Req decorator instead of Request 
This avoids a clash with the Request type from express

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-23 21:20:01 +01:00
David Mehren
e4ba59f154
Don't await non-Promises 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-23 21:14:39 +01:00
David Mehren
e83f1e206b
ESLint: Enable @typescript-eslint/naming-convention rule 
This check enforces consistent variable naming.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-20 21:15:45 +01:00
David Mehren
9485597e6f
ESLint: Enable @typescript-eslint/return-await rule 
This ensures stack traces are helpful at the cost of a slightly
lower performance (one more tick in the event loop).

Fixes #838

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-20 20:14:36 +01:00
David Mehren
2ba824d9e2
ESLint: Re-enable @typescript-eslint/no-explicit-any rule 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-24 21:59:28 +01:00
Philip Molares
0e4b65ca9d
MediaBackendInterface: Correct JSDoc of deleteFile 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-27 12:24:02 +01:00
Philip Molares
2c6af85f14
FilesystemBackend: Remove getFileURL 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-27 11:38:50 +01:00
Philip Molares
4ef3fd029d
MediaBackendInterface: Remove getFileURL 
closes #957

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-26 16:15:46 +01:00
Philip Molares
3aeda955d9
MediaController: Handle MediaBackendErrors 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-25 13:59:32 +01:00
Philip Molares
8e7be737fa
FilesystemBackend: Throw MediaBackendError where appropriate 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-25 13:52:50 +01:00
Philip Molares
8515d824b7
MediaService: Add MediaBackendError 
This get's thrown when the backend can't perform the required action.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-25 13:51:54 +01:00
Philip Molares
df1ae4d512
ConsoleLogger: Add typing to localeStringOptions 
This is necessary as typescript is unable to determine that `year` in this object is of type "numeric" and not string.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-24 10:30:20 +01:00
Philip Molares
0c30f3f0cc
PermissionsModule: Remove unused imports 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-23 19:13:41 +01:00
Yannick Bungers
8b75867664
Rename getNoteContentByNote to getNoteContent 
Signed-off-by: Yannick Bungers <git@innay.de>
 2021-02-22 22:34:18 +01:00
Yannick Bungers
8ec756afb4
Remove unused getNoteContentByIdOrAlias 
Signed-off-by: Yannick Bungers <git@innay.de>
 2021-02-22 22:31:02 +01:00
Yannick Bungers
8873ac316a
Rename viewcount to viewCount for compliance 
Signed-off-by: Yannick Bungers <git@innay.de>
 2021-02-22 23:36:44 +01:00
Philip Molares
4d89ffd474
NotesService: Replace noteByIdOrAlias with note as parameter 
As the NotesController has the note already, because it checked with it if the user has the permission to perform the action, it's not necessary to get the note from the DB again, instead we should just provide the note to the functions directly.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-20 16:50:11 +01:00
Philip Molares
e538056252
NotesController: Handle new errors 
Handle the AlreadyInDB and PermissionsUpdateInconsistent errors and correctly show them to the api user as BadRequest errors.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-20 16:11:51 +01:00
Philip Molares
bafe379cc3
NotesService: Add unit tests 
Fixed toUserDto method of UsersService: If a user has no email an empty string should be returned (like with the photoUrl) instead of null.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-20 16:09:22 +01:00
Philip Molares
128d861512
NotesService: Finished hardcoded functions 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-20 16:09:02 +01:00
Philip Molares
ff61fea96f
Errors: Add AlreadyInDB and PermissionsUpdateInconsistent error 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-20 16:07:09 +01:00
Philip Molares
b1683a5c64
GroupsService: Create new GroupsService 
This service is necessary as we plan to have functions to create and manipulate groups in the future.
The GroupInfoDto was moved from the file note-permissions.dto.ts to mimic the UserInfoDto.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-20 11:41:15 +01:00
Philip Molares
292944ed78
NotePermissions: Remove default constructors 
As discussed in #835 we don't want to have default constructors and prefer .create methods.
Because the created NoteGroupPermission and NoteUserPermission are not saved to the DB by themselves, but are saved via a change to the Note using a Pick<Class, attributes>-style return type is not helpful here as every single time the .create functions are called a full object is required.
The mock calls in the PermissionService test are not needed and break the .create calls so they got removed.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-20 11:38:50 +01:00
Philip Molares
195aeed5eb
NotesService: Add JsDoc strings to all functions 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-20 11:28:19 +01:00
Philip Molares
aa97a87316
NotesService: Rename getCurrentContent to getNoteContentByNote 
The new name should better explain what this functions does.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-19 13:36:01 +01:00
Philip Molares
3953f6893b
NotesController: Catch NotInDBErrors from permission checks 
The permission check also tries to get the note and a non existing note needs to be handled there too.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-17 13:15:26 +01:00
Yannick Bungers
9ac4134198
Add test for permission service 
Many tests are generated and not static like in other files.

Signed-off-by: Yannick Bungers <git@innay.de>
 2021-02-13 14:04:16 +01:00
Yannick Bungers
606d271296
Add guest permission mock and checking 
mocked by attribute of permission service

Signed-off-by: Yannick Bungers <git@innay.de>
 2021-02-13 14:00:29 +01:00
Yannick Bungers
48dedfead8
Add permission checks for notes routes 
Signed-off-by: Yannick Bungers <git@innay.de>
 2021-02-16 09:33:42 +01:00
Yannick Bungers
838b95b8c2
Add permissions Service 
Checks if the given user has sufficient rights on the given resource.

Signed-off-by: Yannick Bungers <git@innay.de>
 2021-02-16 09:32:58 +01:00