From fee8066457281df57bf4dc26f8674ec6be84420f Mon Sep 17 00:00:00 2001 From: Erik Michelson Date: Wed, 11 Dec 2024 17:40:12 +0100 Subject: [PATCH] refactor: use common error message Signed-off-by: Erik Michelson --- lib/web/auth/email/index.js | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/lib/web/auth/email/index.js b/lib/web/auth/email/index.js index 2a434799f..d465e176b 100644 --- a/lib/web/auth/email/index.js +++ b/lib/web/auth/email/index.js @@ -49,17 +49,13 @@ if (config.allowEmailRegister) { password: req.body.password } }).spread(function (user, created) { - if (user) { - if (created) { - logger.debug('user registered: ' + user.id) - req.flash('info', "You've successfully registered, please signin.") - } else { - logger.debug('user found: ' + user.id) - req.flash('error', 'This email has been used, please try another one.') - } + if (user && created) { + logger.debug('user registered: ' + user.id) + req.flash('info', "You've successfully registered, please sign in.") return res.redirect(config.serverURL + '/') } - req.flash('error', 'Failed to register your account, please try again.') + logger.debug('registration failed. user: ', user) + req.flash('error', 'Failed to register your account.') return res.redirect(config.serverURL + '/') }).catch(function (err) { logger.error('auth callback failed: ' + err)