changed calls to cy.route to cy.intercept (#806)

Signed-off-by: Philip Molares <philip.molares@udo.edu>

cypress.json

@@ -1,6 +1,5 @@
 {
   "baseUrl": "http://127.0.0.1:3001/",
   "defaultCommandTimeout": 15000,
-  "experimentalFetchPolyfill": true,
   "video": false
 }

cypress/integration/history.spec.ts

@@ -24,33 +24,66 @@ describe('History', () => {
   })
 
   describe('Pinning', () => {
-    beforeEach(() => {
+    describe('working', () => {
-      cy.route({
+      beforeEach(() => {
-        method: 'PUT',
+        cy.intercept('PUT', '/api/v2/history/features', (req) => {
-        url: '/api/v2/history/**',
+          req.reply(200, req.body)
-        status: 401,
+        })
-        response: {}
+      })
+
+      it('Cards', () => {
+        cy.get('div.card')
+          .should('be.visible')
+        cy.get('.history-pin.btn')
+          .first()
+          .as('pin-button')
+        cy.get('@pin-button')
+          .should('not.have.class', 'pinned')
+          .click()
+        cy.get('@pin-button')
+          .should('have.class', 'pinned')
+      })
+
+      it('Table', () => {
+        cy.get('i.fa-table')
+          .click()
+        cy.get('.history-pin.btn')
+          .first()
+          .as('pin-button')
+        cy.get('@pin-button')
+          .should('not.have.class', 'pinned')
+          .click()
+        cy.get('@pin-button')
+          .should('have.class', 'pinned')
       })
     })
 
-    it('Cards', () => {
+    describe('failing', () => {
-      cy.get('div.card')
+      beforeEach(() => {
-        .should('be.visible')
+        cy.intercept('PUT', '/api/v2/history/features', {
-      cy.get('.fa-thumb-tack')
+          statusCode: 401
-        .first()
+        })
-        .click()
+      })
-      cy.get('.modal-dialog')
-        .should('be.visible')
-    })
 
-    it('Table', () => {
+      it('Cards', () => {
-      cy.get('i.fa-table')
+        cy.get('div.card')
-        .click()
+          .should('be.visible')
-      cy.get('.fa-thumb-tack')
+        cy.get('.fa-thumb-tack')
-        .first()
+          .first()
-        .click()
+          .click()
-      cy.get('.modal-dialog')
+        cy.get('.modal-dialog')
-        .should('be.visible')
+          .should('be.visible')
+      })
+
+      it('Table', () => {
+        cy.get('i.fa-table')
+          .click()
+        cy.get('.fa-thumb-tack')
+          .first()
+          .click()
+        cy.get('.modal-dialog')
+          .should('be.visible')
+      })
     })
   })
 })

cypress/integration/profile.spec.ts

@@ -6,29 +6,32 @@
 
 describe('profile page', () => {
   beforeEach(() => {
-    cy.route({
+    cy.intercept({
       url: '/api/v2/tokens',
-      method: 'GET',
+      method: 'GET'
-      response: [
+    }, {
+      body: [
         {
           label: "cypress-App",
           created: 1601991518
         }
       ]
     })
-    cy.route({
+    cy.intercept({
       url: '/api/v2/tokens',
-      method: 'POST',
+      method: 'POST'
-      response: {
+    }, {
+      body: {
         label: 'cypress',
         secret: 'c-y-p-r-e-s-s',
         created: Date.now()
       }
     })
-    cy.route({
+    cy.intercept({
       url: '/api/v2/tokens/1601991518',
-      method: 'DELETE',
+      method: 'DELETE'
-      response: []
+    }, {
+      body: []
     })
     cy.visit('/profile')
   })

cypress/support/config.ts

@@ -15,10 +15,9 @@ export const branding = {
 }
 
 beforeEach(() => {
-  cy.server()
+  cy.intercept('/api/v2/config', {
-  cy.route({
+    statusCode: 200,
-    url: '/api/v2/config',
+    body: {
-    response: {
       allowAnonymous: true,
       authProviders: {
         facebook: true,

src/components/history-page/history-page.tsx

@@ -153,21 +153,25 @@ export const HistoryPage: React.FC = () => {
         })
       })
     } else if (location === HistoryEntryOrigin.REMOTE) {
-      const entry = remoteHistoryEntries.find(entry => entry.id === entryId)
+      const foundEntry = remoteHistoryEntries.find(entry => entry.id === entryId)
-      if (!entry) {
+      if (!foundEntry) {
         setError('notFoundEntry')
         return
       }
-      entry.pinned = !entry.pinned
+      const changedEntry = {
-      updateHistoryEntry(entryId, entry)
+        ...foundEntry,
-        .then(() => setRemoteHistoryEntries((entries) => {
+        pinned: !foundEntry.pinned
-          return entries.map((entry) => {
+      }
-            if (entry.id === entryId) {
+      updateHistoryEntry(entryId, changedEntry)
-              entry.pinned = !entry.pinned
+        .then(() => setRemoteHistoryEntries((entries) => (
-            }
+          entries.map((entry) => {
-            return entry
+              if (entry.id === entryId) {
-          })
+                entry.pinned = !entry.pinned
-        }))
+              }
+              return entry
+            })
+          )
+        ))
         .catch(() => setError('updateEntry'))
     }
   }, [remoteHistoryEntries])