adjust some review suggestions (#528)

This commit is contained in:
mrdrogdrog 2020-09-02 16:45:25 +02:00 committed by GitHub
parent 528e7e5904
commit df7c4cb19e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 123 additions and 120 deletions

View file

@ -325,7 +325,7 @@ export const MarkdownRenderer: React.FC<MarkdownRendererProps> = ({
new HighlightedCodeReplacer(),
new QuoteOptionsReplacer(),
new KatexReplacer(),
new TaskListReplacer(content, onTaskCheckedChange)
new TaskListReplacer(onTaskCheckedChange)
]
if (onMetaDataChange) {
// This is used if the front-matter callback is never called, because the user deleted everything regarding metadata from the document

View file

@ -3,11 +3,9 @@ import { DomElement } from 'domhandler'
import { ComponentReplacer, SubNodeConverter } from '../ComponentReplacer'
export class TaskListReplacer implements ComponentReplacer {
content: string
onTaskCheckedChange: (lineInMarkdown: number, checked: boolean) => void
constructor (content: string, onTaskCheckedChange: (i: number, checked: boolean) => void) {
this.content = content
constructor (onTaskCheckedChange: (lineInMarkdown: number, checked: boolean) => void) {
this.onTaskCheckedChange = onTaskCheckedChange
}