From d7a3e0f58c62e8059b23b898782b442f7af4aba4 Mon Sep 17 00:00:00 2001
From: Tilman Vatteroth <git@tilmanvatteroth.de>
Date: Fri, 29 Oct 2021 20:54:57 +0200
Subject: [PATCH] Don't throw error if gitlab response is not okay-ish

Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
---
 lib/response.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/response.js b/lib/response.js
index 4d22d563d..44696a55f 100644
--- a/lib/response.js
+++ b/lib/response.js
@@ -153,7 +153,9 @@ function gitlabActionProjects (req, res, note) {
         id: req.user.id
       }
     }).then(function (user) {
-      if (!user) { return errors.errorNotFound(res) }
+      if (!user) {
+        return errors.errorNotFound(res)
+      }
       const ret = { baseURL: config.gitlab.baseURL, version: config.gitlab.version }
       ret.accesstoken = user.accessToken
       ret.profileid = user.profileid
@@ -161,12 +163,14 @@ function gitlabActionProjects (req, res, note) {
       fetch(apiUrl).then(resp => {
         if (!resp.ok) {
           res.send(ret)
-          throw new Error('HTTP request returned not okay-ish status')
+          return Promise.reject(new Error('HTTP request returned not okay-ish status'))
         }
         return resp.json()
       }).then(body => {
         ret.projects = body
         return res.send(ret)
+      }).catch(err => {
+        logger.error('gitlab action projects failed: ', err)
       })
     }).catch(function (err) {
       logger.error('gitlab action projects failed: ' + err)