mirrors/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2025-05-13 06:34:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(test-setup): restructure to synchronous builder

Browse source 
The previous pattern used async methods for the builder pattern,
which were hideous to use when chained multiple times.

This extracts the builder into a separate class
and uses normal functions in the builder.
These queue async functions in arrays, which are executed
at the correct time, when the new async `build` function is called.

Signed-off-by: David Mehren <git@herrmehren.de>
This commit is contained in:
David Mehren 2022-01-06 21:41:36 +01:00
parent 8f1aeab934
commit d1dbd1bb22
13 changed files with 156 additions and 84 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/private-api/notes.e2e-spec.ts
View file

@ -11,7 +11,7 @@ import { AuthConfig } from '../../src/config/auth.config';
import { NotInDBError } from '../../src/errors/errors';
import { User } from '../../src/users/user.entity';
import { setupSessionMiddleware } from '../../src/utils/session';
import { TestSetup } from '../test-setup';
import { TestSetup, TestSetupBuilder } from '../test-setup';
describe('Notes', () => {
let testSetup: TestSetup;
@ -25,7 +25,7 @@ describe('Notes', () => {
let agent: request.SuperAgentTest;
beforeAll(async () => {
testSetup = await TestSetup.create();
testSetup = await TestSetupBuilder.create().build();
forbiddenNoteId =
testSetup.configService.get('appConfig').forbiddenNoteIds[0];