diff --git a/src/notes/alias.entity.ts b/src/notes/alias.entity.ts index 0be2a7d89..70a633f09 100644 --- a/src/notes/alias.entity.ts +++ b/src/notes/alias.entity.ts @@ -54,7 +54,7 @@ export class Alias { // eslint-disable-next-line @typescript-eslint/no-empty-function private constructor() {} - static create(name: string, note: Note, primary = false): Omit { + static create(name: string, note: Note, primary: boolean): Omit { const alias = new Alias(); alias.name = name; alias.primary = primary; diff --git a/src/notes/alias.service.spec.ts b/src/notes/alias.service.spec.ts index 5db8679e3..218b04c30 100644 --- a/src/notes/alias.service.spec.ts +++ b/src/notes/alias.service.spec.ts @@ -140,7 +140,7 @@ describe('AliasService', () => { it('with an already used name', async () => { jest .spyOn(aliasRepo, 'findOne') - .mockResolvedValueOnce(Alias.create(alias2, note) as Alias); + .mockResolvedValueOnce(Alias.create(alias2, note, false) as Alias); await expect(service.addAlias(note, alias2)).rejects.toThrow( AlreadyInDBError, ); @@ -159,7 +159,7 @@ describe('AliasService', () => { const user = User.create('hardcoded', 'Testy') as User; describe('removes one alias correctly', () => { const note = Note.create(user, alias) as Note; - note.aliases.push(Alias.create(alias2, note) as Alias); + note.aliases.push(Alias.create(alias2, note, false) as Alias); it('with two aliases', async () => { jest .spyOn(noteRepo, 'save') @@ -189,7 +189,7 @@ describe('AliasService', () => { }); describe('does not remove one alias', () => { const note = Note.create(user, alias) as Note; - note.aliases.push(Alias.create(alias2, note) as Alias); + note.aliases.push(Alias.create(alias2, note, false) as Alias); it('if the alias is unknown', async () => { await expect(service.removeAlias(note, 'non existent')).rejects.toThrow( NotInDBError, @@ -208,7 +208,7 @@ describe('AliasService', () => { const aliasName = 'testAlias'; const note = Note.create(user, aliasName) as Note; const alias = Alias.create(aliasName, note, true) as Alias; - const alias2 = Alias.create('testAlias2', note) as Alias; + const alias2 = Alias.create('testAlias2', note, false) as Alias; note.aliases.push(alias2); it('mark the alias as primary', async () => { jest diff --git a/src/notes/alias.service.ts b/src/notes/alias.service.ts index 1d5b952b3..96f8c0d55 100644 --- a/src/notes/alias.service.ts +++ b/src/notes/alias.service.ts @@ -66,7 +66,7 @@ export class AliasService { // the first alias is automatically made the primary alias newAlias = Alias.create(alias, note, true); } else { - newAlias = Alias.create(alias, note); + newAlias = Alias.create(alias, note, false); } note.aliases.push(newAlias as Alias);