From bc08493f89d0a39fce268bba3eb79aedba71df37 Mon Sep 17 00:00:00 2001 From: David Mehren Date: Thu, 29 Apr 2021 18:28:32 +0200 Subject: [PATCH] GroupsService: Remove null from toGroupDto return type toGroupDto won't return null, as TS's strict mode prevents group from being nullish Signed-off-by: David Mehren --- src/groups/groups.service.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/groups/groups.service.ts b/src/groups/groups.service.ts index ea2e7fd0d..56878effa 100644 --- a/src/groups/groups.service.ts +++ b/src/groups/groups.service.ts @@ -43,11 +43,7 @@ export class GroupsService { * @param {Group} group - the group to use * @return {GroupInfoDto} the built GroupInfoDto */ - toGroupDto(group: Group | null | undefined): GroupInfoDto | null { - if (!group) { - this.logger.warn(`Recieved ${String(group)} argument!`, 'toGroupDto'); - return null; - } + toGroupDto(group: Group): GroupInfoDto { return { name: group.name, displayName: group.displayName,