diff --git a/src/components/editor-page/editor-pane/tool-bar/utils/upload-image-mimetypes.ts b/src/components/common/upload-image-mimetypes.ts similarity index 80% rename from src/components/editor-page/editor-pane/tool-bar/utils/upload-image-mimetypes.ts rename to src/components/common/upload-image-mimetypes.ts index 1b7bd84f5..7a837ff3d 100644 --- a/src/components/editor-page/editor-pane/tool-bar/utils/upload-image-mimetypes.ts +++ b/src/components/common/upload-image-mimetypes.ts @@ -5,7 +5,6 @@ */ export const supportedMimeTypes: string[] = [ - 'application/pdf', 'image/apng', 'image/bmp', 'image/gif', @@ -19,5 +18,3 @@ export const supportedMimeTypes: string[] = [ 'image/tiff', 'image/webp' ] - -export const supportedMimeTypesJoined = supportedMimeTypes.join(', ') diff --git a/src/components/editor-page/editor-pane/tool-bar/upload-image-button.tsx b/src/components/editor-page/editor-pane/tool-bar/upload-image-button.tsx index 09a1d1d25..8e158e021 100644 --- a/src/components/editor-page/editor-pane/tool-bar/upload-image-button.tsx +++ b/src/components/editor-page/editor-pane/tool-bar/upload-image-button.tsx @@ -11,12 +11,14 @@ import { useTranslation } from 'react-i18next' import { ForkAwesomeIcon } from '../../../common/fork-awesome/fork-awesome-icon' import { UploadInput } from '../../sidebar/upload-input' import { handleUpload } from '../upload-handler' -import { supportedMimeTypesJoined } from './utils/upload-image-mimetypes' +import { supportedMimeTypes } from '../../../common/upload-image-mimetypes' export interface UploadImageButtonProps { editor?: Editor } +const acceptedMimeTypes = supportedMimeTypes.join(', ') + export const UploadImageButton: React.FC = ({ editor }) => { const { t } = useTranslation() const clickRef = useRef<() => void>() @@ -43,7 +45,7 @@ export const UploadImageButton: React.FC = ({ editor }) - + ) } diff --git a/src/components/editor-page/editor-pane/upload-handler.ts b/src/components/editor-page/editor-pane/upload-handler.ts index b379c254d..88087156c 100644 --- a/src/components/editor-page/editor-pane/upload-handler.ts +++ b/src/components/editor-page/editor-pane/upload-handler.ts @@ -8,7 +8,7 @@ import { Editor } from 'codemirror' import i18n from 'i18next' import { uploadFile } from '../../../api/media' import { store } from '../../../redux' -import { supportedMimeTypes } from './tool-bar/utils/upload-image-mimetypes' +import { supportedMimeTypes } from '../../common/upload-image-mimetypes' export const handleUpload = (file: File, editor: Editor): void => { if (!file) { @@ -25,7 +25,7 @@ export const handleUpload = (file: File, editor: Editor): void => { uploadFile(noteId, file) .then(({ link }) => { editor.replaceRange( - getCorrectSyntaxForLink(mimeType, link), + `![](${link})`, cursor, { line: cursor.line, @@ -46,12 +46,3 @@ export const handleUpload = (file: File, editor: Editor): void => { ) }) } - -const getCorrectSyntaxForLink = (mimeType: string, link: string): string => { - switch (mimeType) { - case 'application/pdf': - return `{%pdf ${link} %}` - default: - return `![](${link})` - } -}