fix(media): initialize backends only if configured

Signed-off-by: Erik Michelson <erik@michelson.eu>

backend/src/media/backends/azure-backend.ts

@@ -35,16 +35,17 @@ export class AzureBackend implements MediaBackend {
     private mediaConfig: MediaConfig,
   ) {
     this.logger.setContext(AzureBackend.name);
-    this.config = (this.mediaConfig.backend as AzureMediaConfig).azure;
+    // only create the backend if azure is configured
-    if (this.mediaConfig.backend.use === BackendType.AZURE) {
+    if (this.mediaConfig.backend.use !== BackendType.AZURE) {
-      // only create the client if the backend is configured to azure
+      return;
-      const blobServiceClient = BlobServiceClient.fromConnectionString(
-        this.config.connectionString,
-      );
-      this.credential =
-        blobServiceClient.credential as StorageSharedKeyCredential;
-      this.client = blobServiceClient.getContainerClient(this.config.container);
     }
+    this.config = this.mediaConfig.backend.azure;
+    const blobServiceClient = BlobServiceClient.fromConnectionString(
+      this.config.connectionString,
+    );
+    this.credential =
+      blobServiceClient.credential as StorageSharedKeyCredential;
+    this.client = blobServiceClient.getContainerClient(this.config.container);
   }
 
   async saveFile(

backend/src/media/backends/filesystem-backend.ts

@@ -8,13 +8,11 @@ import { FileTypeResult } from 'file-type';
 import { promises as fs } from 'fs';
 import { join } from 'path';
 
-import mediaConfiguration, {
+import mediaConfiguration, { MediaConfig } from '../../config/media.config';
-  FilesystemMediaConfig,
-  MediaConfig,
-} from '../../config/media.config';
 import { MediaBackendError } from '../../errors/errors';
 import { ConsoleLoggerService } from '../../logger/console-logger.service';
 import { MediaBackend } from '../media-backend.interface';
+import { BackendType } from './backend-type.enum';
 
 @Injectable()
 export class FilesystemBackend implements MediaBackend {
@@ -26,9 +24,12 @@ export class FilesystemBackend implements MediaBackend {
     private mediaConfig: MediaConfig,
   ) {
     this.logger.setContext(FilesystemBackend.name);
-    this.uploadDirectory = (
+    // only create the backend if local filesystem is configured
-      this.mediaConfig.backend as FilesystemMediaConfig
+    if (this.mediaConfig.backend.use !== BackendType.FILESYSTEM) {
-    ).filesystem.uploadPath;
+      this.uploadDirectory = '';
+      return;
+    }
+    this.uploadDirectory = this.mediaConfig.backend.filesystem.uploadPath;
   }
 
   async saveFile(

backend/src/media/backends/imgur-backend.ts

@@ -14,6 +14,7 @@ import mediaConfiguration, {
 import { MediaBackendError } from '../../errors/errors';
 import { ConsoleLoggerService } from '../../logger/console-logger.service';
 import { MediaBackend } from '../media-backend.interface';
+import { BackendType } from './backend-type.enum';
 
 type UploadResult = {
   data: {
@@ -37,7 +38,11 @@ export class ImgurBackend implements MediaBackend {
     private mediaConfig: MediaConfig,
   ) {
     this.logger.setContext(ImgurBackend.name);
-    this.config = (this.mediaConfig.backend as ImgurMediaConfig).imgur;
+    // only create the backend if imgur is configured
+    if (this.mediaConfig.backend.use !== BackendType.IMGUR) {
+      return;
+    }
+    this.config = this.mediaConfig.backend.imgur;
   }
 
   async saveFile(uuid: string, buffer: Buffer): Promise<string> {

backend/src/media/backends/s3-backend.ts

@@ -33,6 +33,7 @@ export class S3Backend implements MediaBackend {
     private mediaConfig: MediaConfig,
   ) {
     this.logger.setContext(S3Backend.name);
+    // only create the backend if s3 is configured
     if (this.mediaConfig.backend.use !== BackendType.S3) {
       return;
     }

backend/src/media/backends/webdav-backend.ts

@@ -29,37 +29,37 @@ export class WebdavBackend implements MediaBackend {
     private mediaConfig: MediaConfig,
   ) {
     this.logger.setContext(WebdavBackend.name);
-    if (this.mediaConfig.backend.use === BackendType.WEBDAV) {
+    // only create the backend if WebDAV is configured
-      this.config = this.mediaConfig.backend.webdav;
+    if (this.mediaConfig.backend.use !== BackendType.WEBDAV) {
-      const url = new URL(this.config.connectionString);
+      return;
-      this.baseUrl = url.toString();
-      if (this.config.uploadDir && this.config.uploadDir !== '') {
-        this.baseUrl = WebdavBackend.joinURL(
-          this.baseUrl,
-          this.config.uploadDir,
-        );
-      }
-      this.authHeader = WebdavBackend.generateBasicAuthHeader(
-        url.username,
-        url.password,
-      );
-      fetch(this.baseUrl, {
-        method: 'PROPFIND',
-        headers: {
-          Accept: 'text/plain', // eslint-disable-line @typescript-eslint/naming-convention
-          Authorization: this.authHeader, // eslint-disable-line @typescript-eslint/naming-convention
-          Depth: '0', // eslint-disable-line @typescript-eslint/naming-convention
-        },
-      })
-        .then((response) => {
-          if (!response.ok) {
-            throw new Error(`Can't access ${this.baseUrl}`);
-          }
-        })
-        .catch(() => {
-          throw new Error(`Can't access ${this.baseUrl}`);
-        });
     }
+
+    this.config = this.mediaConfig.backend.webdav;
+    const url = new URL(this.config.connectionString);
+    this.baseUrl = url.toString();
+    if (this.config.uploadDir && this.config.uploadDir !== '') {
+      this.baseUrl = WebdavBackend.joinURL(this.baseUrl, this.config.uploadDir);
+    }
+    this.authHeader = WebdavBackend.generateBasicAuthHeader(
+      url.username,
+      url.password,
+    );
+    fetch(this.baseUrl, {
+      method: 'PROPFIND',
+      headers: {
+        Accept: 'text/plain', // eslint-disable-line @typescript-eslint/naming-convention
+        Authorization: this.authHeader, // eslint-disable-line @typescript-eslint/naming-convention
+        Depth: '0', // eslint-disable-line @typescript-eslint/naming-convention
+      },
+    })
+      .then((response) => {
+        if (!response.ok) {
+          throw new Error(`Can't access ${this.baseUrl}`);
+        }
+      })
+      .catch(() => {
+        throw new Error(`Can't access ${this.baseUrl}`);
+      });
   }
 
   async saveFile(