Use "untitled" fallback in history entry without title (#1546)

This commit is contained in:
Erik Michelson 2021-10-24 21:08:28 +02:00 committed by GitHub
parent 8096267161
commit 9118c8310b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 129 additions and 53 deletions

View file

@ -5,25 +5,84 @@
*/
describe('History', () => {
beforeEach(() => {
cy.visit('/history')
})
describe('History Mode', () => {
beforeEach(() => {
cy.visit('/history')
})
it('Cards', () => {
cy.get('div.card')
.should('be.visible')
cy.get('div.card').should('be.visible')
})
it('Table', () => {
cy.get('i.fa-table')
.click()
cy.get('table.history-table')
.should('be.visible')
cy.get('[data-cypress-id="history-mode-table"]').click()
cy.get('[data-cypress-id="history-table"]').should('be.visible')
})
})
describe('entry title', () => {
describe('is as given when not empty', () => {
beforeEach(() => {
cy.clearLocalStorage('history')
cy.intercept('GET', '/mock-backend/api/private/me/history', {
body: [
{
identifier: 'cypress',
title: 'Features',
lastVisited: '2020-05-16T22:26:56.547Z',
pinStatus: false,
tags: []
}
]
})
cy.visit('/history')
})
it('in table view', () => {
cy.get('[data-cypress-id="history-mode-table"]').click()
cy.get('[data-cypress-id="history-table"]').should('be.visible')
cy.get('[data-cypress-id="history-entry-title"]').contains('Features')
})
it('in cards view', () => {
cy.get('[data-cypress-id="history-entry-title"]').contains('Features')
})
})
describe('is untitled when not empty', () => {
beforeEach(() => {
cy.clearLocalStorage('history')
cy.intercept('GET', '/mock-backend/api/private/me/history', {
body: [
{
identifier: 'cypress-no-title',
title: '',
lastVisited: '2020-05-16T22:26:56.547Z',
pinStatus: false,
tags: []
}
]
})
cy.visit('/history')
})
it('in table view', () => {
cy.get('[data-cypress-id="history-mode-table"]').click()
cy.get('[data-cypress-id="history-table"]').should('be.visible')
cy.get('[data-cypress-id="history-entry-title"]').contains('Untitled')
})
it('in cards view', () => {
cy.get('[data-cypress-id="history-entry-title"]').contains('Untitled')
})
})
})
describe('Pinning', () => {
beforeEach(() => {
cy.visit('/history')
})
describe('working', () => {
beforeEach(() => {
cy.intercept('PUT', '/mock-backend/api/private/me/history/features', (req) => {
@ -32,29 +91,17 @@ describe('History', () => {
})
it('Cards', () => {
cy.get('div.card')
.should('be.visible')
cy.get('.history-pin.btn')
.first()
.as('pin-button')
cy.get('@pin-button')
.should('have.class', 'pinned')
.click()
cy.get('@pin-button')
.should('not.have.class', 'pinned')
cy.get('div.card').should('be.visible')
cy.get('.history-pin.btn').first().as('pin-button')
cy.get('@pin-button').should('have.class', 'pinned').click()
cy.get('@pin-button').should('not.have.class', 'pinned')
})
it('Table', () => {
cy.get('i.fa-table')
.click()
cy.get('.history-pin.btn')
.first()
.as('pin-button')
cy.get('@pin-button')
.should('have.class', 'pinned')
.click()
cy.get('@pin-button')
.should('not.have.class', 'pinned')
cy.get('i.fa-table').click()
cy.get('.history-pin.btn').first().as('pin-button')
cy.get('@pin-button').should('have.class', 'pinned').click()
cy.get('@pin-button').should('not.have.class', 'pinned')
})
})
@ -66,23 +113,15 @@ describe('History', () => {
})
it('Cards', () => {
cy.get('div.card')
.should('be.visible')
cy.get('.fa-thumb-tack')
.first()
.click()
cy.get('.notifications-area .toast')
.should('be.visible')
cy.get('div.card').should('be.visible')
cy.get('.fa-thumb-tack').first().click()
cy.get('.notifications-area .toast').should('be.visible')
})
it('Table', () => {
cy.get('i.fa-table')
.click()
cy.get('.fa-thumb-tack')
.first()
.click()
cy.get('.notifications-area .toast')
.should('be.visible')
cy.get('i.fa-table').click()
cy.get('.fa-thumb-tack').first().click()
cy.get('.notifications-area .toast').should('be.visible')
})
})
})