mirrors/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2025-06-06 17:41:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Adding issues for TODOs

Browse source 
Signed-off-by: Yannick Bungers <git@innay.de>
This commit is contained in:
Yannick Bungers 2023-10-07 20:35:58 +02:00 • committed by David Mehren
parent 7e1123e8a4
commit 8879b51344
16 changed files with 21 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

1
frontend/src/components/editor-page/sidebar/sidebar.tsx
View file

@ -66,6 +66,7 @@ export const Sidebar: React.FC = () => {
onClick={toggleValue}
/>
<ShareNoteSidebarEntry hide={selectionIsNotNone} />
{/* TODO only show if user has permissions (Owner) (https://github.com/hedgedoc/hedgedoc/issues/5036) */}
<DeleteNoteSidebarEntry hide={selectionIsNotNone} />
<PinNoteSidebarEntry hide={selectionIsNotNone} />
</div>

2
frontend/src/components/editor-page/sidebar/specific-sidebar-entries/revisions-sidebar-entry/revisions-modal/revision-modal-footer.tsx
View file

@ -42,7 +42,7 @@ export const RevisionModalFooter: React.FC<RevisionModalFooterProps> = ({
const onRevertToRevision = useCallback(() => {
// TODO Websocket message handler missing
// see https://github.com/hedgedoc/hedgedoc/issues/1984
// see https://github.com/hedgedoc/hedgedoc/issues/1984
window.alert('Not yet implemented. Requires websocket.')
}, [])

2
frontend/src/components/history-page/entry-menu/entry-menu.tsx
View file

@ -76,7 +76,7 @@ export const EntryMenu: React.FC<EntryMenuProps> = ({
<RemoveNoteEntryItem onConfirm={onRemoveFromHistory} noteTitle={title} />
{/* TODO Check permissions (ownership) before showing option for delete */}
{/* TODO Check permissions (ownership) before showing option for delete (https://github.com/hedgedoc/hedgedoc/issues/5036)*/}
<ShowIf condition={userExists}>
<Dropdown.Divider />
<DeleteNoteItem onConfirm={onDeleteNote} noteTitle={title} />

1
frontend/src/components/history-page/history-toolbar/import-history-button.tsx
View file

@ -65,6 +65,7 @@ export const ImportHistoryButton: React.FC = () => {
}
//TODO: [mrdrogdrog] The following whole block can be shortened using our `readFile` util.
// But I won't do it right now because the whole components needs a make over and that's definitely out of scope for my current PR.
// https://github.com/hedgedoc/hedgedoc/issues/5042
const fileReader = new FileReader()
fileReader.onload = (event) => {
if (event.target && event.target.result) {

2
frontend/src/components/render-page/renderers/document/width-based-table-of-contents.tsx
View file

@ -22,7 +22,7 @@ const MAX_WIDTH_FOR_BUTTON_VISIBILITY = 1100
*
* @param tocAst the {@link TocAst AST} that should be rendered.
* @param width the width that should be used to determine if the button should be shown.
* @param baseUrl the base url that will be used to generate the links //TODO: replace with consumer/provider
* @param baseUrl the base url that will be used to generate the links //TODO: replace with consumer/provider (https://github.com/hedgedoc/hedgedoc/issues/5035)
*/
export const WidthBasedTableOfContents: React.FC<DocumentExternalTocProps> = ({ tocAst, width, baseUrl }) => {
if (width >= MAX_WIDTH_FOR_BUTTON_VISIBILITY) {