Adding issues for TODOs

Signed-off-by: Yannick Bungers <git@innay.de>
This commit is contained in:
Yannick Bungers 2023-10-07 20:35:58 +02:00 committed by David Mehren
parent 7e1123e8a4
commit 8879b51344
16 changed files with 21 additions and 16 deletions

View file

@ -47,7 +47,7 @@ export class ApiResponse<ResponseType> {
throw new Error('Response body does not seem to be JSON encoded.')
}
// TODO Responses should better be type validated
// see https://github.com/hedgedoc/hedgedoc/issues/2910
// see https://github.com/hedgedoc/hedgedoc/issues/2910
return (await this.response.json()) as ResponseType
}
}

View file

@ -86,7 +86,7 @@ export const deleteNote = async (noteIdOrAlias: string): Promise<void> => {
.withJsonBody({
keepMedia: false
// TODO Ask whether the user wants to keep the media uploaded to the note.
// https://github.com/hedgedoc/hedgedoc/issues/2928
// https://github.com/hedgedoc/hedgedoc/issues/2928
})
.sendRequest()
}

View file

@ -30,8 +30,7 @@ const EditorPage: NextPage<PageParams> = ({ params }) => {
/*
TODO: implement these in generateMetadata. We need these only in SSR.
See https://github.com/hedgedoc/hedgedoc/issues/4766
See https://github.com/hedgedoc/hedgedoc/issues/4766
But its problematic because we dont get the opengraph meta data via API.

View file

@ -66,6 +66,7 @@ export const Sidebar: React.FC = () => {
onClick={toggleValue}
/>
<ShareNoteSidebarEntry hide={selectionIsNotNone} />
{/* TODO only show if user has permissions (Owner) (https://github.com/hedgedoc/hedgedoc/issues/5036) */}
<DeleteNoteSidebarEntry hide={selectionIsNotNone} />
<PinNoteSidebarEntry hide={selectionIsNotNone} />
</div>

View file

@ -42,7 +42,7 @@ export const RevisionModalFooter: React.FC<RevisionModalFooterProps> = ({
const onRevertToRevision = useCallback(() => {
// TODO Websocket message handler missing
// see https://github.com/hedgedoc/hedgedoc/issues/1984
// see https://github.com/hedgedoc/hedgedoc/issues/1984
window.alert('Not yet implemented. Requires websocket.')
}, [])

View file

@ -76,7 +76,7 @@ export const EntryMenu: React.FC<EntryMenuProps> = ({
<RemoveNoteEntryItem onConfirm={onRemoveFromHistory} noteTitle={title} />
{/* TODO Check permissions (ownership) before showing option for delete */}
{/* TODO Check permissions (ownership) before showing option for delete (https://github.com/hedgedoc/hedgedoc/issues/5036)*/}
<ShowIf condition={userExists}>
<Dropdown.Divider />
<DeleteNoteItem onConfirm={onDeleteNote} noteTitle={title} />

View file

@ -65,6 +65,7 @@ export const ImportHistoryButton: React.FC = () => {
}
//TODO: [mrdrogdrog] The following whole block can be shortened using our `readFile` util.
// But I won't do it right now because the whole components needs a make over and that's definitely out of scope for my current PR.
// https://github.com/hedgedoc/hedgedoc/issues/5042
const fileReader = new FileReader()
fileReader.onload = (event) => {
if (event.target && event.target.result) {

View file

@ -22,7 +22,7 @@ const MAX_WIDTH_FOR_BUTTON_VISIBILITY = 1100
*
* @param tocAst the {@link TocAst AST} that should be rendered.
* @param width the width that should be used to determine if the button should be shown.
* @param baseUrl the base url that will be used to generate the links //TODO: replace with consumer/provider
* @param baseUrl the base url that will be used to generate the links //TODO: replace with consumer/provider (https://github.com/hedgedoc/hedgedoc/issues/5035)
*/
export const WidthBasedTableOfContents: React.FC<DocumentExternalTocProps> = ({ tocAst, width, baseUrl }) => {
if (width >= MAX_WIDTH_FOR_BUTTON_VISIBILITY) {

View file

@ -18,7 +18,8 @@ export class ForkAwesomeHtmlTagAppExtension extends AppExtension {
return [
new SingleLineRegexLinter(
forkAwesomeRegex,
t('editor.linter.fork-awesome', { link: 'https://docs.hedgedoc.org' }) // ToDo: Add correct link here
// ToDo: Add correct link here (https://github.com/hedgedoc/hedgedoc/issues/5021)
t('editor.linter.fork-awesome', { link: 'https://docs.hedgedoc.org' })
)
]
}