Adding issues for TODOs

Signed-off-by: Yannick Bungers <git@innay.de>
This commit is contained in:
Yannick Bungers 2023-10-07 20:35:58 +02:00 committed by David Mehren
parent 7e1123e8a4
commit 8879b51344
16 changed files with 21 additions and 16 deletions

View file

@ -299,6 +299,7 @@ export default registerAs('authConfig', () => {
idpCert: process.env[`HD_AUTH_SAML_${samlName}_IDP_CERT`],
clientCert: process.env[`HD_AUTH_SAML_${samlName}_CLIENT_CERT`],
// ToDo: (default: config.serverURL) will be build on-the-fly in the config/index.js from domain, urlAddPort and urlPath.
// https://github.com/hedgedoc/hedgedoc/issues/5043
issuer: process.env[`HD_AUTH_SAML_${samlName}_ISSUER`],
identifierFormat:
process.env[`HD_AUTH_SAML_${samlName}_IDENTIFIER_FORMAT`],

View file

@ -106,7 +106,7 @@ export class IdentityService {
shouldSave = true;
}
if (profilePicture) {
// ToDo: sync image
// ToDo: sync image (https://github.com/hedgedoc/hedgedoc/issues/5032)
}
if (shouldSave) {
identity.user = Promise.resolve(user);

View file

@ -149,7 +149,7 @@ export class ConsoleLoggerService implements LoggerService {
day: '2-digit',
month: '2-digit',
};
//TODO make timestamp optional
//TODO make timestamp optional (https://github.com/hedgedoc/hedgedoc/issues/5033)
const timestamp = new Date(Date.now()).toLocaleString(
undefined,
localeStringOptions,

View file

@ -10,8 +10,7 @@ import { ServerStatusDto } from './server-status.dto';
@Injectable()
export class MonitoringService {
// TODO Implement Server Status and other routes
// (https://github.com/hedgedoc/hedgedoc/issues/478)
// TODO Implement Server Status and other routes (https://github.com/hedgedoc/hedgedoc/issues/478)
async getServerStatus(): Promise<ServerStatusDto> {
return {
connectionSocketQueueLength: 0,

View file

@ -67,6 +67,7 @@ export class WebsocketGateway implements OnGatewayConnection {
);
if (notePermission < NotePermission.READ) {
//TODO: [mrdrogdrog] inform client about reason of disconnect.
// (https://github.com/hedgedoc/hedgedoc/issues/5034)
this.logger.log(
`Access denied to note '${note.id}' for user '${username}'`,
'handleConnection',

View file

@ -46,9 +46,9 @@ describe('App', () => {
/**
* TODO: This is not really a regression test, as it does not use the
* real initialization code in main.ts.
* Should be fixed after https://github.com/hedgedoc/hedgedoc/issues/2083
* is done.
* real initialization code in main.ts.
* Should be fixed after https://github.com/hedgedoc/hedgedoc/issues/2083
* is done.
*/
const app = moduleRef.createNestApplication();
app.useWebSocketAdapter(new WsAdapter(app));