mirrors/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2025-05-28 14:04:43 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: option to disable note creation
Some checks failed
Build & run tests / Node ${{ matrix.node }} (18) (push) Has been cancelled
Details
Build & run tests / Node ${{ matrix.node }} (20) (push) Has been cancelled
Details
Lint / Lint files (push) Has been cancelled
Details

Browse source 
The abuse of the demo instance required us to disallow note creation

Signed-off-by: Erik Michelson <github@erik.michelson.eu>
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
This commit is contained in:
Erik Michelson 2024-07-18 00:25:20 +02:00 • committed by Tilman Vatteroth
parent c85b11463d
commit 858d7bf5d1
9 changed files with 20 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lib/config/default.js
View file

@ -35,6 +35,7 @@ module.exports = {
allowAnonymousEdits: false,
allowFreeURL: false,
requireFreeURLAuthentication: false,
disableNoteCreation: false,
forbiddenNoteIDs: ['robots.txt', 'favicon.ico', 'api', 'build', 'css', 'docs', 'fonts', 'js', 'uploads', 'vendor', 'views'],
defaultPermission: 'editable',
dbURL: '',

1
lib/config/environment.js
View file

@ -33,6 +33,7 @@ module.exports = {
allowAnonymousEdits: toBooleanConfig(process.env.CMD_ALLOW_ANONYMOUS_EDITS),
allowFreeURL: toBooleanConfig(process.env.CMD_ALLOW_FREEURL),
requireFreeURLAuthentication: toBooleanConfig(process.env.CMD_REQUIRE_FREEURL_AUTHENTICATION),
disableNoteCreation: toBooleanConfig(process.env.CMD_DISABLE_NOTE_CREATION),
forbiddenNoteIDs: toArrayConfig(process.env.CMD_FORBIDDEN_NOTE_IDS),
defaultPermission: process.env.CMD_DEFAULT_PERMISSION,
dbURL: process.env.CMD_DB_URL,

3
lib/web/note/controller.js
View file

@ -82,6 +82,9 @@ exports.showNote = function (req, res, next) {
}
exports.createFromPOST = function (req, res, next) {
if (config.disableNoteCreation) {
return errors.errorForbidden(res)
}
let body = ''
if (req.body && req.body.length > config.documentMaxLength) {
return errors.errorTooLong(res)

6
lib/web/note/util.js
View file

@ -19,7 +19,11 @@ exports.findNote = function (req, res, callback, include = null, createIfNotFoun
include: include || null
}).then(function (note) {
if (!note && createIfNotFound) {
return exports.newNote(req, res, '')
if (config.disableNoteCreation) {
return errors.errorNotFound(res)
} else {
return exports.newNote(req, res, '')
}
}
if (!note && !createIfNotFound) {
return errors.errorNotFound(res)