switching to eslint for code checking

most rules degraded to WARN, so we don't go insane. This will
change over time. The aim is to conform to a common style

Signed-off-by: Claudius Coenen <opensource@amenthes.de>

public/.eslintrc.js

@@ -0,0 +1,28 @@
+// this config file is used in concert with the root .eslintrc.js in the root dir.
+module.exports = {
+  "env": {
+    "browser": true
+  },
+  "globals": {
+    "$": false,
+    "CodeMirror": false,
+    "Cookies": false,
+    "moment": false,
+    "editor": false,
+    "ui": false,
+    "Spinner": false,
+    "modeType": false,
+    "Idle": false,
+    "serverurl": false,
+    "key": false,
+    "gapi": false,
+    "Dropbox": false,
+    "FilePicker": false,
+    "ot": false,
+    "MediaUploader": false,
+    "hex2rgb": false,
+    "num_loaded": false,
+    "Visibility": false,
+    "inlineAttachment": false
+  }
+};

public/js/history.js

@@ -218,6 +218,7 @@ export function getStorageHistory (callback) {
     if (typeof data === 'string') { data = JSON.parse(data) }
     callback(data)
   }
+  // eslint-disable-next-line standard/no-callback-literal
   callback([])
 }
 

public/js/index.js

@@ -2511,7 +2511,9 @@ function buildCursor (user) {
 // editor actions
 function removeNullByte (cm, change) {
   var str = change.text.join('\n')
+  // eslint-disable-next-line no-control-regex
   if (/\u0000/g.test(str) && change.update) {
+    // eslint-disable-next-line no-control-regex
     change.update(change.from, change.to, str.replace(/\u0000/g, '').split('\n'))
   }
 }
@@ -3046,7 +3048,7 @@ function checkInCode () {
 function checkAbove (method) {
   var cursor = editor.getCursor()
   var text = []
-  for (var i = 0; i < cursor.line; i++) {  // contain current line
+  for (var i = 0; i < cursor.line; i++) { // contain current line
     text.push(editor.getLine(i))
   }
   text = text.join('\n') + '\n' + editor.getLine(cursor.line).slice(0, cursor.ch)

public/js/lib/editor/index.js

@@ -492,7 +492,7 @@ export default class Editor {
             clearInterval(spellcheckTimer)
           }
         },
-        100,
+        100
       )
     }
   }
@@ -514,7 +514,7 @@ export default class Editor {
   }
   setOverrideBrowserKeymap () {
     var overrideBrowserKeymap = $(
-      '.ui-preferences-override-browser-keymap label > input[type="checkbox"]',
+      '.ui-preferences-override-browser-keymap label > input[type="checkbox"]'
     )
     if (overrideBrowserKeymap.is(':checked')) {
       Cookies.set('preferences-override-browser-keymap', true, {
@@ -529,10 +529,10 @@ export default class Editor {
 
   setPreferences () {
     var overrideBrowserKeymap = $(
-      '.ui-preferences-override-browser-keymap label > input[type="checkbox"]',
+      '.ui-preferences-override-browser-keymap label > input[type="checkbox"]'
     )
     var cookieOverrideBrowserKeymap = Cookies.get(
-      'preferences-override-browser-keymap',
+      'preferences-override-browser-keymap'
     )
     if (cookieOverrideBrowserKeymap && cookieOverrideBrowserKeymap === 'true') {
       overrideBrowserKeymap.prop('checked', true)

public/js/lib/editor/ui-elements.js

@@ -67,7 +67,7 @@ export const getUIElements = () => ({
     codemirrorScroll: $('.ui-edit-area .CodeMirror .CodeMirror-scroll'),
     codemirrorSizer: $('.ui-edit-area .CodeMirror .CodeMirror-sizer'),
     codemirrorSizerInner: $(
-      '.ui-edit-area .CodeMirror .CodeMirror-sizer > div',
+      '.ui-edit-area .CodeMirror .CodeMirror-sizer > div'
     ),
     markdown: $('.ui-view-area .markdown-body'),
     resize: {