mirrors/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2025-05-16 16:14:43 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Remove a tag childs from NextJS link components

Browse source 
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
This commit is contained in:
Tilman Vatteroth 2022-11-06 16:15:57 +01:00 • committed by David Mehren
parent cb74cb21ed
commit 7f7f020d91
7 changed files with 39 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/components/common/redirect.tsx
View file

@ -32,10 +32,7 @@ export const Redirect: React.FC<RedirectProps> = ({ to }) => {
return ( return (
<span {...testId('redirect')}> <span {...testId('redirect')}>
Redirecting to{' '} Redirecting to <Link href={to}>{to}</Link>
<Link href={to}>
<a>{to}</a>
</Link>
</span> </span>
) )
} }

4
src/components/editor-page/app-bar/navbar-branding.tsx
View file

@ -23,14 +23,12 @@ export const NavbarBranding: React.FC = () => {
return ( return (
<Navbar.Brand> <Navbar.Brand>
<Link href='/intro'> <Link href='/intro' className='text-secondary text-decoration-none d-flex align-items-center'>
<a className='text-secondary text-decoration-none d-flex align-items-center'>
<HedgeDocLogoWithText <HedgeDocLogoWithText
logoType={darkModeActivated ? HedgeDocLogoType.WB_HORIZONTAL : HedgeDocLogoType.BW_HORIZONTAL} logoType={darkModeActivated ? HedgeDocLogoType.WB_HORIZONTAL : HedgeDocLogoType.BW_HORIZONTAL}
size={HedgeDocLogoSize.SMALL} size={HedgeDocLogoSize.SMALL}
/> />
<Branding inline={true} /> <Branding inline={true} />
</a>
</Link> </Link>
</Navbar.Brand> </Navbar.Brand>
) )

4
src/components/editor-page/app-bar/read-only-mode-button.tsx
View file

@ -19,8 +19,7 @@ export const ReadOnlyModeButton: React.FC = () => {
const noteIdentifier = useApplicationState((state) => state.noteDetails.primaryAddress) const noteIdentifier = useApplicationState((state) => state.noteDetails.primaryAddress)
return ( return (
<Link href={`/s/${noteIdentifier}`}> <Link href={`/s/${noteIdentifier}`} target='_blank'>
<a target='_blank'>
<Button <Button
title={t('editor.documentBar.readOnlyMode')} title={t('editor.documentBar.readOnlyMode')}
className='ms-2 text-secondary' className='ms-2 text-secondary'
@ -28,7 +27,6 @@ export const ReadOnlyModeButton: React.FC = () => {
variant='outline-light'> variant='outline-light'>
<ForkAwesomeIcon icon='file-text-o' /> <ForkAwesomeIcon icon='file-text-o' />
</Button> </Button>
</a>
</Link> </Link>
) )
} }

4
src/components/editor-page/app-bar/slide-mode-button.tsx
View file

@ -19,8 +19,7 @@ export const SlideModeButton: React.FC = () => {
const noteIdentifier = useApplicationState((state) => state.noteDetails.primaryAddress) const noteIdentifier = useApplicationState((state) => state.noteDetails.primaryAddress)
return ( return (
<Link href={`/p/${noteIdentifier}`}> <Link href={`/p/${noteIdentifier}`} target='_blank'>
<a target='_blank'>
<Button <Button
title={t('editor.documentBar.slideMode')} title={t('editor.documentBar.slideMode')}
className='ms-2 text-secondary' className='ms-2 text-secondary'
@ -28,7 +27,6 @@ export const SlideModeButton: React.FC = () => {
variant='outline-light'> variant='outline-light'>
<ForkAwesomeIcon icon='television' /> <ForkAwesomeIcon icon='television' />
</Button> </Button>
</a>
</Link> </Link>
) )
} }

4
src/components/history-page/history-card/history-card.tsx
View file

@ -64,8 +64,7 @@ export const HistoryCard: React.FC<HistoryEntryProps & HistoryEventHandlers> = (
<div className={'d-flex flex-column'}> <div className={'d-flex flex-column'}>
<PinButton isDark={false} isPinned={entry.pinStatus} onPinClick={onPinEntry} /> <PinButton isDark={false} isPinned={entry.pinStatus} onPinClick={onPinEntry} />
</div> </div>
<Link href={`/n/${entry.identifier}`}> <Link href={`/n/${entry.identifier}`} className='text-decoration-none flex-fill text-dark'>
<a className='text-decoration-none flex-fill text-dark'>
<div className={'d-flex flex-column justify-content-between'}> <div className={'d-flex flex-column justify-content-between'}>
<Card.Title className='m-0 mt-1dot5' {...cypressId('history-entry-title')}> <Card.Title className='m-0 mt-1dot5' {...cypressId('history-entry-title')}>
{entryTitle} {entryTitle}
@ -79,7 +78,6 @@ export const HistoryCard: React.FC<HistoryEntryProps & HistoryEventHandlers> = (
<div className={`${styles['card-footer-min-height']} p-0`}>{tags}</div> <div className={`${styles['card-footer-min-height']} p-0`}>{tags}</div>
</div> </div>
</div> </div>
</a>
</Link> </Link>
<div className={'d-flex flex-column'}> <div className={'d-flex flex-column'}>
<EntryMenu <EntryMenu

4
src/components/history-page/history-table/history-table-row.tsx
View file

@ -45,10 +45,8 @@ export const HistoryTableRow: React.FC<HistoryEntryProps & HistoryEventHandlers>
return ( return (
<tr> <tr>
<td> <td>
<Link href={`/n/${entry.identifier}`}> <Link href={`/n/${entry.identifier}`} className='text-light' {...cypressId('history-entry-title')}>
<a className='text-light' {...cypressId('history-entry-title')}>
{entryTitle} {entryTitle}
</a>
</Link> </Link>
</td> </td>
<td>{formatHistoryDate(entry.lastVisitedAt)}</td> <td>{formatHistoryDate(entry.lastVisitedAt)}</td>

4
src/components/landing-layout/navigation/header-bar/header-nav-link.tsx
View file

@ -33,10 +33,8 @@ export const HeaderNavLink: React.FC<PropsWithChildren<HeaderNavLinkProps>> = ({
return ( return (
<Nav.Item> <Nav.Item>
<Link href={to} passHref={true}> <Link href={to} className={`nav-link text-light ${activeClass} ${styles['nav-link']}`} {...cypressId(props)}>
<a className={`nav-link text-light ${activeClass} ${styles['nav-link']}`} href={to} {...cypressId(props)}>
{children} {children}
</a>
</Link> </Link>
</Nav.Item> </Nav.Item>
) )