mirrors/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2025-05-13 22:54:42 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

test(e2e): fix notes service

Browse source 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
This commit is contained in:
Philip Molares 2022-08-23 18:01:45 +02:00 • committed by Yannick Bungers
parent 5cdc0edfb9
commit 754e725b7f
4 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/notes/notes.service.ts
View file

@ -63,6 +63,13 @@ export class NotesService {
async getUserNotes(user: User): Promise<Note[]> { async getUserNotes(user: User): Promise<Note[]> {
const notes = await this.noteRepository const notes = await this.noteRepository
.createQueryBuilder('note') .createQueryBuilder('note')
.leftJoinAndSelect('note.aliases', 'alias')
.leftJoinAndSelect('note.owner', 'owner')
.leftJoinAndSelect('note.groupPermissions', 'group_permission')
.leftJoinAndSelect('group_permission.group', 'group')
.leftJoinAndSelect('note.userPermissions', 'user_permission')
.leftJoinAndSelect('user_permission.user', 'user')
.leftJoinAndSelect('note.tags', 'tag')
.where('note.owner = :user', { user: user.id }) .where('note.owner = :user', { user: user.id })
.getMany(); .getMany();
if (notes === null) { if (notes === null) {
@ -275,8 +282,6 @@ export class NotesService {
//TODO: Calculate patch //TODO: Calculate patch
revisions.push(Revision.create(noteContent, noteContent, note) as Revision); revisions.push(Revision.create(noteContent, noteContent, note) as Revision);
note.revisions = Promise.resolve(revisions); note.revisions = Promise.resolve(revisions);
note.userPermissions = Promise.resolve([]);
note.groupPermissions = Promise.resolve([]);
return await this.noteRepository.save(note); return await this.noteRepository.save(note);
} }

2
src/permissions/note-group-permission.entity.ts
View file

@ -1,5 +1,5 @@
/* /*
* SPDX-FileCopyrightText: 2021 The HedgeDoc developers (see AUTHORS file) * SPDX-FileCopyrightText: 2022 The HedgeDoc developers (see AUTHORS file)
* *
* SPDX-License-Identifier: AGPL-3.0-only * SPDX-License-Identifier: AGPL-3.0-only
*/ */

6
test/private-api/notes.e2e-spec.ts
View file

@ -414,6 +414,12 @@ describe('Notes', () => {
user2, user2,
alias, alias,
); );
// Redact default read permissions
const note = await testSetup.notesService.getNoteByIdOrAlias(alias);
const everyone = await testSetup.groupService.getEveryoneGroup();
const loggedin = await testSetup.groupService.getLoggedInGroup();
await testSetup.permissionsService.removeGroupPermission(note, everyone);
await testSetup.permissionsService.removeGroupPermission(note, loggedin);
await agent await agent
.get(`/api/private/notes/${alias}/media/`) .get(`/api/private/notes/${alias}/media/`)
.expect('Content-Type', /json/) .expect('Content-Type', /json/)

7
test/public-api/notes.e2e-spec.ts
View file

@ -189,7 +189,6 @@ describe('Notes', () => {
const note = await testSetup.notesService.createNote( const note = await testSetup.notesService.createNote(
content, content,
user, user,
'test3', 'test3',
); );
const updateNotePermission = new NotePermissionsUpdateDto(); const updateNotePermission = new NotePermissionsUpdateDto();
@ -465,6 +464,12 @@ describe('Notes', () => {
user2, user2,
alias, alias,
); );
// Redact default read permissions
const note = await testSetup.notesService.getNoteByIdOrAlias(alias);
const everyone = await testSetup.groupService.getEveryoneGroup();
const loggedin = await testSetup.groupService.getLoggedInGroup();
await testSetup.permissionsService.removeGroupPermission(note, everyone);
await testSetup.permissionsService.removeGroupPermission(note, loggedin);
await request(testSetup.app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get(`/api/v2/notes/${alias}/media/`) .get(`/api/v2/notes/${alias}/media/`)
.expect('Content-Type', /json/) .expect('Content-Type', /json/)