mirrors/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2025-05-24 20:14:35 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix(note-deletion): Add required keepMedia property and redirect

Browse source 
The backend requires a property "keepMedia" that states whether uploaded media should be kept around or not.
This property was missing in our API call.
Additionally, after deleting a note, the user is now redirected to the history page.

Signed-off-by: Erik Michelson <github@erik.michelson.eu>
This commit is contained in:
Erik Michelson 2022-08-14 23:12:56 +02:00
parent d57b2f27fd
commit 6cc11d07e3
3 changed files with 25 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/components/editor-page/sidebar/delete-note-sidebar-entry/delete-note-sidebar-entry.tsx
View file

@ -15,6 +15,10 @@ import { showErrorNotification } from '../../../../redux/ui-notifications/method
import { deleteNote } from '../../../../api/notes'
import { DeleteNoteModal } from './delete-note-modal'
import { useBooleanState } from '../../../../hooks/common/use-boolean-state'
import { useRouter } from 'next/router'
import { Logger } from '../../../../utils/logger'
const logger = new Logger('note-deletion')
/**
* Sidebar entry that can be used to delete the current note.
@ -24,11 +28,17 @@ import { useBooleanState } from '../../../../hooks/common/use-boolean-state'
*/
export const DeleteNoteSidebarEntry: React.FC<PropsWithChildren<SpecificSidebarEntryProps>> = ({ hide, className }) => {
useTranslation()
const router = useRouter()
const noteId = useApplicationState((state) => state.noteDetails.id)
const [modalVisibility, showModal, closeModal] = useBooleanState()
const deleteNoteAndCloseDialog = useCallback(() => {
deleteNote(noteId).catch(showErrorNotification('landing.history.error.deleteNote.text')).finally(closeModal)
}, [closeModal, noteId])
deleteNote(noteId)
.then(() => {
router.push('/history').catch((reason) => logger.error('Error while redirecting to /history', reason))
})
.catch(showErrorNotification('landing.history.error.deleteNote.text'))
.finally(closeModal)
}, [closeModal, noteId, router])
return (
<Fragment>