mirrors/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2025-05-19 01:35:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

NotesService: updateNoteByIdOrAlias should return the new note

Browse source 
Fixes #702

Signed-off-by: David Mehren <git@herrmehren.de>
This commit is contained in:
David Mehren 2021-01-10 20:30:45 +01:00
parent 4a1bec8eec
commit 6301a264dd
No known key found for this signature in database
GPG key ID: 185982BA4C42B7C3
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/notes/notes.service.ts
View file

@ -13,7 +13,7 @@ import { Revision } from '../revisions/revision.entity';
import { RevisionsService } from '../revisions/revisions.service'; import { RevisionsService } from '../revisions/revisions.service';
import { User } from '../users/user.entity'; import { User } from '../users/user.entity';
import { UsersService } from '../users/users.service'; import { UsersService } from '../users/users.service';
import { NoteMetadataDto, NoteMetadataUpdateDto } from './note-metadata.dto'; import { NoteMetadataDto } from './note-metadata.dto';
import { import {
NotePermissionsDto, NotePermissionsDto,
NotePermissionsUpdateDto, NotePermissionsUpdateDto,
@ -192,6 +192,7 @@ export class NotesService {
revisions.push(Revision.create(noteContent, noteContent)); revisions.push(Revision.create(noteContent, noteContent));
note.revisions = Promise.resolve(revisions); note.revisions = Promise.resolve(revisions);
await this.noteRepository.save(note); await this.noteRepository.save(note);
return this.toNoteDto(note);
} }
async getNoteMetadata(noteIdOrAlias: string): Promise<NoteMetadataDto> { async getNoteMetadata(noteIdOrAlias: string): Promise<NoteMetadataDto> {

3
test/public-api/notes.e2e-spec.ts
View file

@ -103,7 +103,7 @@ describe('Notes', () => {
it(`PUT /notes/{note}`, async () => { it(`PUT /notes/{note}`, async () => {
await notesService.createNote('This is a test note.', 'test4'); await notesService.createNote('This is a test note.', 'test4');
await request(app.getHttpServer()) const response = await request(app.getHttpServer())
.put('/notes/test4') .put('/notes/test4')
.set('Content-Type', 'text/markdown') .set('Content-Type', 'text/markdown')
.send('New note text') .send('New note text')
@ -111,6 +111,7 @@ describe('Notes', () => {
await expect( await expect(
(await notesService.getNoteDtoByIdOrAlias('test4')).content, (await notesService.getNoteDtoByIdOrAlias('test4')).content,
).toEqual('New note text'); ).toEqual('New note text');
expect(response.body.content).toEqual('New note text');
// check if a missing note correctly returns 404 // check if a missing note correctly returns 404
await request(app.getHttpServer()) await request(app.getHttpServer())