From 61e092e8affcc3b39a944fe866624737ff4717dd Mon Sep 17 00:00:00 2001 From: Tilman Vatteroth Date: Sun, 3 Apr 2022 21:36:04 +0200 Subject: [PATCH] Force change of aria-hidden when modal shows or hides Signed-off-by: Tilman Vatteroth --- public/docs/release-notes.md | 1 + public/js/cover.js | 2 ++ public/js/fix-aria-hidden-for-modals.js | 5 +++++ public/js/index.js | 1 + 4 files changed, 9 insertions(+) create mode 100644 public/js/fix-aria-hidden-for-modals.js diff --git a/public/docs/release-notes.md b/public/docs/release-notes.md index 038133d5f..2fad1a254 100644 --- a/public/docs/release-notes.md +++ b/public/docs/release-notes.md @@ -5,6 +5,7 @@ ### Bugfixes - Fix error that Libravatar user avatars were not shown when using OAuth2 login - Fix `bin/manage_users` not accepting numeric passwords (thanks to [@carr0t2](https://github.com/carr0t2) for reporting) +- Fix visibility of modals for screen readers ### Enhancements - Libravatar avatars render as ident-icons when no avatar image was uploaded to Libravatar or Gravatar diff --git a/public/js/cover.js b/public/js/cover.js index bad925742..7aba372d0 100644 --- a/public/js/cover.js +++ b/public/js/cover.js @@ -32,6 +32,8 @@ require('./locale') require('../css/cover.css') require('../css/site.css') +require('./fix-aria-hidden-for-modals') + const options = { valueNames: ['id', 'text', 'timestamp', 'fromNow', 'time', 'tags', 'pinned'], item: `
  • diff --git a/public/js/fix-aria-hidden-for-modals.js b/public/js/fix-aria-hidden-for-modals.js new file mode 100644 index 000000000..a9ec6dbd4 --- /dev/null +++ b/public/js/fix-aria-hidden-for-modals.js @@ -0,0 +1,5 @@ +$(document).on('shown.bs.modal', function (event) { + $(event.target).attr('aria-hidden', 'false') +}).on('hidden.bs.modal', function (event) { + $(event.target).attr('aria-hidden', 'true') +}) diff --git a/public/js/index.js b/public/js/index.js index a61a3c3cb..716477c51 100644 --- a/public/js/index.js +++ b/public/js/index.js @@ -93,6 +93,7 @@ require('../css/slide-preview.css') require('../css/site.css') require('highlight.js/styles/github-gist.css') +require('./fix-aria-hidden-for-modals') let defaultTextHeight = 20 let viewportMargin = 20