diff --git a/src/components/element-separator/element-separator.tsx b/src/components/element-separator/element-separator.tsx index f9cb33021..14d065d75 100644 --- a/src/components/element-separator/element-separator.tsx +++ b/src/components/element-separator/element-separator.tsx @@ -8,13 +8,18 @@ export const ElementSeparator: React.FC = ({children, sep return ( { - React.Children.map(children, (child, index) => { - return - { - (index > 0) ? separator : null - } - {child} - + React.Children + .toArray(children) + .filter(child => child !== null) + .map((child, index) => { + return ( + + { + (index > 0 ) ? separator : null + } + {child} + + ) }) } diff --git a/src/components/landing/pages/login/login.tsx b/src/components/landing/pages/login/login.tsx index 66a0d8be3..5c3671553 100644 --- a/src/components/landing/pages/login/login.tsx +++ b/src/components/landing/pages/login/login.tsx @@ -8,6 +8,7 @@ import {useSelector} from "react-redux"; import {ApplicationState} from "../../../../redux"; import {ViaOpenId} from "./auth/via-open id"; import "./login.scss"; +import {ElementSeparator} from "../../../element-separator/element-separator"; const Login: React.FC = () => { useTranslation(); @@ -16,8 +17,6 @@ const Login: React.FC = () => { const emailForm = authProviders.email ? : null const ldapForm = authProviders.ldap ? : null const openIdForm = authProviders.openid ? : null - const emailLdapSeparator = authProviders.email && authProviders.ldap ?
: null - const ldapOpenIdSeparator = authProviders.ldap && authProviders.openid ?
: null const oneClickCustomName: (type: OneClickType) => string | undefined = (type) => { switch (type) { @@ -35,13 +34,13 @@ const Login: React.FC = () => {
{ - authProviders.email || authProviders.ldap ? + authProviders.email || authProviders.ldap || authProviders.openid ? - {emailForm} - {emailLdapSeparator} - {ldapForm} - {ldapOpenIdSeparator} - {openIdForm} + }> + {emailForm} + {ldapForm} + {openIdForm} +
: null