mirrors/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2025-05-19 01:35:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(revision): lazy-load relations

Browse source 
Signed-off-by: David Mehren <git@herrmehren.de>
This commit is contained in:
David Mehren 2021-12-05 21:38:36 +01:00
parent e73bd7c030
commit 2da6faa4b4
No known key found for this signature in database
GPG key ID: 185982BA4C42B7C3
3 changed files with 11 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/notes/notes.service.spec.ts
View file

@ -711,7 +711,7 @@ describe('NotesService', () => {
.mockImplementation(async (note: Note): Promise<Note> => note);
const note = await service.createNote(content, null);
const revisions = await note.revisions;
revisions[0].edits = [
revisions[0].edits = Promise.resolve([
{
revisions: Promise.resolve(revisions),
startPos: 0,
@ -726,7 +726,7 @@ describe('NotesService', () => {
updatedAt: new Date(1549312452001),
author: Promise.resolve(author),
} as Edit,
];
]);
revisions[0].createdAt = new Date(1549312452000);
jest.spyOn(revisionRepo, 'findOne').mockResolvedValue(revisions[0]);
const createQueryBuilder = {
@ -810,7 +810,7 @@ describe('NotesService', () => {
.mockImplementation(async (note: Note): Promise<Note> => note);
const note = await service.createNote(content, null);
const revisions = await note.revisions;
revisions[0].edits = [
revisions[0].edits = Promise.resolve([
{
revisions: Promise.resolve(revisions),
startPos: 0,
@ -825,7 +825,7 @@ describe('NotesService', () => {
updatedAt: new Date(1549312452001),
author: Promise.resolve(author),
} as Edit,
];
]);
revisions[0].createdAt = new Date(1549312452000);
jest
.spyOn(revisionRepo, 'findOne')

5
src/notes/notes.service.ts
View file

@ -340,11 +340,12 @@ export class NotesService {
*/
async calculateUpdateUser(note: Note): Promise<User | null> {
const lastRevision = await this.getLatestRevision(note);
if (lastRevision && lastRevision.edits) {
const edits = await lastRevision.edits;
if (edits.length > 0) {
// Sort the last Revisions Edits by their updatedAt Date to get the latest one
// the user of that Edit is the updateUser
return await (
await lastRevision.edits.sort(
await edits.sort(
(a, b) => b.updatedAt.getTime() - a.updatedAt.getTime(),
)[0].author
).user;