From 1c5c3c325871895ea97aaacde921759caa7bc41c Mon Sep 17 00:00:00 2001 From: Tilman Vatteroth Date: Wed, 9 Jun 2021 22:07:36 +0200 Subject: [PATCH] Deduplicate code Signed-off-by: Tilman Vatteroth --- .../editor-page/editor-pane/upload-handler.ts | 26 +++++-------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/src/components/editor-page/editor-pane/upload-handler.ts b/src/components/editor-page/editor-pane/upload-handler.ts index 88087156c..b45b2220b 100644 --- a/src/components/editor-page/editor-pane/upload-handler.ts +++ b/src/components/editor-page/editor-pane/upload-handler.ts @@ -21,28 +21,16 @@ export const handleUpload = (file: File, editor: Editor): void => { const cursor = editor.getCursor() const uploadPlaceholder = `![${i18n.t('editor.upload.uploadFile', { fileName: file.name })}]()` const noteId = store.getState().noteDetails.id + const insertCode = (replacement: string) => { + editor.replaceRange(replacement, cursor, { line: cursor.line, ch: cursor.ch + uploadPlaceholder.length }, '+input') + } editor.replaceRange(uploadPlaceholder, cursor, cursor, '+input') uploadFile(noteId, file) .then(({ link }) => { - editor.replaceRange( - `![](${link})`, - cursor, - { - line: cursor.line, - ch: cursor.ch + uploadPlaceholder.length - }, - '+input' - ) + insertCode(`![](${link})`) }) - .catch(() => { - editor.replaceRange( - '', - cursor, - { - line: cursor.line, - ch: cursor.ch + uploadPlaceholder.length - }, - '+input' - ) + .catch((error) => { + console.error('error while uploading file', error) + insertCode('') }) }