diff --git a/src/_h5ai/client/js/inc/view/viewmode.js b/src/_h5ai/client/js/inc/view/viewmode.js index 9941142b..b70570df 100644 --- a/src/_h5ai/client/js/inc/view/viewmode.js +++ b/src/_h5ai/client/js/inc/view/viewmode.js @@ -91,7 +91,7 @@ modulejs.define('view/viewmode', ['_', '$', 'core/resource', 'core/settings', 'c return; } - var $viewBlock = $('

View

'); + var $viewBlock = $('

View

'); var max; settings.modes = _.intersection(settings.modes, modes); @@ -112,7 +112,7 @@ modulejs.define('view/viewmode', ['_', '$', 'core/resource', 'core/settings', 'c .prop('max', max).attr('max', max) .on('input change', function (ev) { - updateView(null, settings.sizes[parseInt(ev.target.value, 10)]); + updateView(null, settings.sizes[ev.target.valueAsNumber]); }) .appendTo($viewBlock); } diff --git a/test/tests/integration/view.js b/test/tests/integration/view.js index 1056b651..d8d31883 100644 --- a/test/tests/integration/view.js +++ b/test/tests/integration/view.js @@ -113,10 +113,10 @@ describe('view', function () { assert.lengthOf($('#toolbar > #sidebar-toggle'), 1); }); - it('adds HTML .block viewmode to #sidebar', function () { + it('adds HTML #settings-viewmode to #sidebar', function () { modulejs.require('view/viewmode'); - assert.lengthOf($('#sidebar > .block > .l10n-view'), 1); + assert.lengthOf($('#sidebar > #settings-viewmode'), 1); }); it('adds style to head', function () { diff --git a/test/tests/unit/view/viewmode.js b/test/tests/unit/view/viewmode.js index 758c78f2..f915e5b7 100644 --- a/test/tests/unit/view/viewmode.js +++ b/test/tests/unit/view/viewmode.js @@ -86,34 +86,34 @@ describe('module \'' + ID + '\'', function () { assert.isUndefined(instance); }); - it('adds HTML .block to #sidebar', function () { + it('adds HTML #settings-viewmode to #sidebar', function () { this.applyFn(); - assert.lengthOf($('#sidebar > .block > .l10n-view'), 1); + assert.lengthOf($('#sidebar > #settings-viewmode'), 1); }); - it('adds HTML #view-details to .block', function () { + it('adds HTML #view-details to #settings-viewmode', function () { this.applyFn(); - assert.lengthOf($('#sidebar > .block > #view-details'), 1); + assert.lengthOf($('#settings-viewmode > #view-details'), 1); }); - it('adds HTML #view-grid to .block', function () { + it('adds HTML #view-grid to #settings-viewmode', function () { this.applyFn(); - assert.lengthOf($('#sidebar > .block > #view-grid'), 1); + assert.lengthOf($('#settings-viewmode > #view-grid'), 1); }); - it('adds HTML #view-icons to .block', function () { + it('adds HTML #view-icons to #settings-viewmode', function () { this.applyFn(); - assert.lengthOf($('#sidebar > .block > #view-icons'), 1); + assert.lengthOf($('#settings-viewmode > #view-icons'), 1); }); - it('adds HTML #view-size to .block', function () { + it('adds HTML #view-size to #settings-viewmode', function () { this.applyFn(); - assert.lengthOf($('#sidebar > .block > #view-size'), 1); + assert.lengthOf($('#settings-viewmode > #view-size'), 1); }); it('adds style to head', function () {