From 77d6da3a246d9f2d21aa311282e5a0003a0c5344 Mon Sep 17 00:00:00 2001
From: Lars Jung <lrsjng@gmail.com>
Date: Sat, 2 May 2015 03:59:22 +0200
Subject: [PATCH] Refactor PHP code.

---
 src/_h5ai/server/php/inc/class-api.php | 27 +++++---------------------
 src/_h5ai/server/php/inc/class-app.php |  2 +-
 2 files changed, 6 insertions(+), 23 deletions(-)

diff --git a/src/_h5ai/server/php/inc/class-api.php b/src/_h5ai/server/php/inc/class-api.php
index feb119f8..d25d8aed 100644
--- a/src/_h5ai/server/php/inc/class-api.php
+++ b/src/_h5ai/server/php/inc/class-api.php
@@ -41,29 +41,12 @@ class Api {
 
         $response = array();
 
-        if (Util::get_boolean_request_param("setup", false)) {
+        foreach (array("setup", "options", "types", "theme", "langs") as $name) {
+            if (Util::get_boolean_request_param($name, false)) {
 
-            $response["setup"] = $this->app->get_setup();
-        }
-
-        if (Util::get_boolean_request_param("options", false)) {
-
-            $response["options"] = $this->app->get_options();
-        }
-
-        if (Util::get_boolean_request_param("types", false)) {
-
-            $response["types"] = $this->app->get_types();
-        }
-
-        if (Util::get_boolean_request_param("theme", false)) {
-
-            $response["theme"] = $this->app->get_theme();
-        }
-
-        if (Util::get_boolean_request_param("langs", false)) {
-
-            $response["langs"] = $this->app->get_l10n_list();
+                $methodname = "get_${name}";
+                $response[$name] = $this->app->$methodname();
+            }
         }
 
         if (Util::get_boolean_request_param("l10n", false)) {
diff --git a/src/_h5ai/server/php/inc/class-app.php b/src/_h5ai/server/php/inc/class-app.php
index 4557bb94..088d7664 100644
--- a/src/_h5ai/server/php/inc/class-app.php
+++ b/src/_h5ai/server/php/inc/class-app.php
@@ -259,7 +259,7 @@ class App {
     }
 
 
-    public function get_l10n_list() {
+    public function get_langs() {
 
         $langs = array();
         $l10n_path = APP_PATH . "/conf/l10n";