mirrors/h5ai
1
0
Fork 0
mirror of https://github.com/lrsjng/h5ai.git synced 2025-06-01 15:58:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor notifications.

Browse source
This commit is contained in:
Lars Jung 2015-04-29 00:57:58 +02:00
parent 6500b624f5
commit 73496c6b7c
6 changed files with 40 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/tests/unit/core/location.js
View file

@ -2,7 +2,7 @@
'use strict';
var ID = 'core/location';
var DEPS = ['_', 'modernizr', 'core/event', 'core/notify', 'core/settings'];
var DEPS = ['_', 'modernizr', 'core/event', 'core/settings', 'view/notification'];
describe('module \'' + ID + '\'', function () {
@ -21,16 +21,16 @@ describe('module \'' + ID + '\'', function () {
pub: sinon.stub(),
sub: sinon.stub()
};
this.xNotify = {
this.xNotification = {
set: sinon.stub()
};
this.applyFn = function () {
this.xEvent.pub.reset();
this.xEvent.sub.reset();
this.xNotify.set.reset();
this.xNotification.set.reset();
return this.definition.fn(_, this.xModernizr, this.xEvent, this.xNotify, this.xSettings);
return this.definition.fn(_, this.xModernizr, this.xEvent, this.xSettings, this.xNotification);
};
});

111
test/tests/unit/core/notify.js
View file

@ -1,111 +0,0 @@
(function () {
'use strict';
var ID = 'core/notify';
var DEPS = ['$'];
describe('module \'' + ID + '\'', function () {
before(function () {
this.definition = modulejs._private.definitions[ID];
this.applyFn = function () {
return this.definition.fn($);
};
});
after(function () {
util.restoreHtml();
});
beforeEach(function () {
util.restoreHtml();
});
describe('definition', function () {
it('is defined', function () {
assert.isPlainObject(this.definition);
});
it('has correct id', function () {
assert.strictEqual(this.definition.id, ID);
});
it('requires correct', function () {
assert.deepEqual(this.definition.deps, DEPS);
});
it('args for each request', function () {
assert.strictEqual(this.definition.deps.length, this.definition.fn.length);
});
it('has no instance', function () {
assert.notProperty(modulejs._private.instances, ID);
});
it('inits without errors', function () {
this.applyFn();
});
});
describe('application', function () {
it('returns plain object with 1 property', function () {
var instance = this.applyFn();
assert.isPlainObject(instance);
assert.lengthOfKeys(instance, 1);
});
it('adds HTML', function () {
this.applyFn();
assert.lengthOf($('#notify'), 1);
assert.lengthOf($('#notify:visible'), 0);
assert.strictEqual($('#notify').text(), '');
});
});
describe('.set()', function () {
it('is function', function () {
var instance = this.applyFn();
assert.ok(_.isFunction(instance.set));
});
it('works', function () {
var instance = this.applyFn();
instance.set();
assert.lengthOf($('#notify:visible'), 0);
assert.strictEqual($('#notify').text(), '');
instance.set('hello');
assert.lengthOf($('#notify:visible'), 1);
assert.strictEqual($('#notify').text(), 'hello');
instance.set('world');
assert.lengthOf($('#notify:visible'), 1);
assert.strictEqual($('#notify').text(), 'world');
instance.set();
// assert.lengthOf($('#notify:visible'), 0);
assert.strictEqual($('#notify').text(), 'world');
});
});
});
}());