From 1cba9290b602b8488684ea6137be03ab26ff6f91 Mon Sep 17 00:00:00 2001 From: Lars Jung Date: Fri, 3 Jun 2016 22:40:05 +0200 Subject: [PATCH] Refactor win.js into globals.js. --- ghu.js | 2 +- src/_h5ai/public/js/global.js | 9 +++---- src/_h5ai/public/js/lib/config.js | 6 ++--- src/_h5ai/public/js/lib/core/event.js | 2 +- src/_h5ai/public/js/lib/core/format.js | 2 +- src/_h5ai/public/js/lib/core/langs.js | 4 +-- src/_h5ai/public/js/lib/core/location.js | 4 +-- src/_h5ai/public/js/lib/core/resource.js | 2 +- src/_h5ai/public/js/lib/core/server.js | 2 +- src/_h5ai/public/js/lib/core/store.js | 2 +- src/_h5ai/public/js/lib/core/types.js | 2 +- src/_h5ai/public/js/lib/core/util.js | 2 +- src/_h5ai/public/js/lib/ext/autorefresh.js | 8 +++--- src/_h5ai/public/js/lib/ext/contextmenu.js | 3 ++- src/_h5ai/public/js/lib/ext/crumb.js | 2 +- src/_h5ai/public/js/lib/ext/custom.js | 2 +- src/_h5ai/public/js/lib/ext/download.js | 2 +- src/_h5ai/public/js/lib/ext/filter.js | 2 +- .../public/js/lib/ext/google-analytics.js | 2 +- src/_h5ai/public/js/lib/ext/info.js | 2 +- src/_h5ai/public/js/lib/ext/l10n.js | 4 +-- src/_h5ai/public/js/lib/ext/peer5.js | 2 +- .../public/js/lib/ext/piwik-analytics.js | 2 +- src/_h5ai/public/js/lib/ext/preview-aud.js | 10 ++++---- src/_h5ai/public/js/lib/ext/preview-img.js | 10 ++++---- src/_h5ai/public/js/lib/ext/preview-txt.js | 12 ++++----- src/_h5ai/public/js/lib/ext/preview-vid.js | 10 ++++---- src/_h5ai/public/js/lib/ext/preview.js | 6 ++--- src/_h5ai/public/js/lib/ext/search.js | 2 +- src/_h5ai/public/js/lib/ext/select.js | 3 ++- src/_h5ai/public/js/lib/ext/sort.js | 2 +- src/_h5ai/public/js/lib/ext/thumbnails.js | 2 +- src/_h5ai/public/js/lib/ext/title.js | 3 ++- src/_h5ai/public/js/lib/ext/tree.js | 2 +- src/_h5ai/public/js/lib/globals.js | 14 +++++++++++ src/_h5ai/public/js/lib/init.js | 24 +++++++++--------- src/_h5ai/public/js/lib/main/index.js | 4 +-- src/_h5ai/public/js/lib/main/info.js | 2 +- src/_h5ai/public/js/lib/model/item.js | 2 +- src/_h5ai/public/js/lib/view/content.js | 2 +- src/_h5ai/public/js/lib/view/mainrow.js | 2 +- src/_h5ai/public/js/lib/view/notification.js | 2 +- src/_h5ai/public/js/lib/view/root.js | 2 +- src/_h5ai/public/js/lib/view/sidebar.js | 2 +- src/_h5ai/public/js/lib/view/topbar.js | 2 +- src/_h5ai/public/js/lib/view/view.js | 2 +- src/_h5ai/public/js/lib/view/viewmode.js | 2 +- src/_h5ai/public/js/lib/win.js | 5 ---- test/.eslintrc | 25 ++----------------- 49 files changed, 106 insertions(+), 118 deletions(-) create mode 100644 src/_h5ai/public/js/lib/globals.js delete mode 100644 src/_h5ai/public/js/lib/win.js diff --git a/ghu.js b/ghu.js index 9bef5e0a..a2419650 100644 --- a/ghu.js +++ b/ghu.js @@ -68,7 +68,7 @@ ghu.task('build:scripts', runtime => { return read(`${SRC}/_h5ai/public/js/scripts.js`) .then(newerThan(mapper, `${SRC}/_h5ai/public/js/**`)) - .then(webpack(webpackConfig, {showStats: true})) + .then(webpack(webpackConfig, {showStats: false})) .then(wrap('\n\n// @include "global.js"\n\n')) .then(includeit()) .then(ife(() => runtime.args.production, uglify())) diff --git a/src/_h5ai/public/js/global.js b/src/_h5ai/public/js/global.js index 020b63b5..64970ccd 100644 --- a/src/_h5ai/public/js/global.js +++ b/src/_h5ai/public/js/global.js @@ -1,6 +1,5 @@ -(function check(win) { - /* eslint-disable func-names,no-console,no-var */ - +/* eslint-disable func-names,no-var */ +(function (win) { if (typeof win !== 'object' || win.window !== win || !win.document) { throw new Error('no-window'); } @@ -14,7 +13,6 @@ docEl.className = noBrowser; throw new Error(noBrowser + ': ' + msg); } - win.console.log('checked: ' + msg); } assert('console', win.console && typeof win.console.log === 'function'); @@ -37,9 +35,8 @@ return false; } }())); - - /* eslint-enable no-var */ }(this)); +/* eslint-enable */ // @include "vendor/*.js" diff --git a/src/_h5ai/public/js/lib/config.js b/src/_h5ai/public/js/lib/config.js index a624c613..9614a9f8 100644 --- a/src/_h5ai/public/js/lib/config.js +++ b/src/_h5ai/public/js/lib/config.js @@ -1,9 +1,9 @@ const {request} = require('./core/server'); const config = module.exports = { - _update: data => { - return request(data).then(newConfig => { - Object.assign(config, newConfig); + _update: query => { + return request(query).then(response => { + Object.assign(config, response); return config; }); } diff --git a/src/_h5ai/public/js/lib/core/event.js b/src/_h5ai/public/js/lib/core/event.js index 6dc67b0b..655e385a 100644 --- a/src/_h5ai/public/js/lib/core/event.js +++ b/src/_h5ai/public/js/lib/core/event.js @@ -1,4 +1,4 @@ -const {_: lo} = require('../win'); +const {lo} = require('../globals'); const subscriptions = {}; diff --git a/src/_h5ai/public/js/lib/core/format.js b/src/_h5ai/public/js/lib/core/format.js index 5eab78b4..1bb52f69 100644 --- a/src/_h5ai/public/js/lib/core/format.js +++ b/src/_h5ai/public/js/lib/core/format.js @@ -1,4 +1,4 @@ -const {_: lo} = require('../win'); +const {lo} = require('../globals'); const decimalMetric = { t: 1000.0, diff --git a/src/_h5ai/public/js/lib/core/langs.js b/src/_h5ai/public/js/lib/core/langs.js index b78bfcd5..1a2f8435 100644 --- a/src/_h5ai/public/js/lib/core/langs.js +++ b/src/_h5ai/public/js/lib/core/langs.js @@ -1,2 +1,2 @@ -const config = require('../config'); -module.exports = Object.assign({}, config.langs); +const {langs} = require('../config'); +module.exports = Object.assign({}, langs); diff --git a/src/_h5ai/public/js/lib/core/location.js b/src/_h5ai/public/js/lib/core/location.js index 8c2f0d94..893f555d 100644 --- a/src/_h5ai/public/js/lib/core/location.js +++ b/src/_h5ai/public/js/lib/core/location.js @@ -1,11 +1,11 @@ -const {window: win, document: doc, _: lo} = require('../win'); +const {win, lo} = require('../globals'); const {request} = require('./server'); const allsettings = require('./settings'); const event = require('./event'); const notification = require('../view/notification'); - +const doc = win.document; const settings = lo.extend({ fastBrowsing: true, unmanagedInNewWindow: true diff --git a/src/_h5ai/public/js/lib/core/resource.js b/src/_h5ai/public/js/lib/core/resource.js index 785d5719..6b9fda7f 100644 --- a/src/_h5ai/public/js/lib/core/resource.js +++ b/src/_h5ai/public/js/lib/core/resource.js @@ -1,4 +1,4 @@ -const {_: lo} = require('../win'); +const {lo} = require('../globals'); const config = require('../config'); const settings = require('./settings'); diff --git a/src/_h5ai/public/js/lib/core/server.js b/src/_h5ai/public/js/lib/core/server.js index 473c9377..ebcf302c 100644 --- a/src/_h5ai/public/js/lib/core/server.js +++ b/src/_h5ai/public/js/lib/core/server.js @@ -1,4 +1,4 @@ -const {jQuery: jq, _: lo} = require('../win'); +const {jq, lo} = require('../globals'); function request(data) { return new Promise(resolve => { diff --git a/src/_h5ai/public/js/lib/core/store.js b/src/_h5ai/public/js/lib/core/store.js index be29705c..eae92a12 100644 --- a/src/_h5ai/public/js/lib/core/store.js +++ b/src/_h5ai/public/js/lib/core/store.js @@ -1,4 +1,4 @@ -const win = require('../win'); +const {win} = require('../globals'); const store = win.localStorage; const storekey = '_h5ai'; diff --git a/src/_h5ai/public/js/lib/core/types.js b/src/_h5ai/public/js/lib/core/types.js index 88cf51dc..ca1a9fe1 100644 --- a/src/_h5ai/public/js/lib/core/types.js +++ b/src/_h5ai/public/js/lib/core/types.js @@ -1,4 +1,4 @@ -const {_: lo} = require('../win'); +const {lo} = require('../globals'); const config = require('../config'); const reEndsWithSlash = /\/$/; diff --git a/src/_h5ai/public/js/lib/core/util.js b/src/_h5ai/public/js/lib/core/util.js index 48682a03..4161a564 100644 --- a/src/_h5ai/public/js/lib/core/util.js +++ b/src/_h5ai/public/js/lib/core/util.js @@ -1,4 +1,4 @@ -const {_: lo} = require('../win'); +const {lo} = require('../globals'); function regularCmpFn(val1, val2) { if (val1 < val2) { diff --git a/src/_h5ai/public/js/lib/ext/autorefresh.js b/src/_h5ai/public/js/lib/ext/autorefresh.js index b407e33b..3f4c485b 100644 --- a/src/_h5ai/public/js/lib/ext/autorefresh.js +++ b/src/_h5ai/public/js/lib/ext/autorefresh.js @@ -1,4 +1,4 @@ -const {setTimeout} = require('../win'); +const {win} = require('../globals'); const event = require('../core/event'); const location = require('../core/location'); const allsettings = require('../core/settings'); @@ -16,12 +16,12 @@ function heartbeat() { } function before() { - clearTimeout(timeoutId); + win.clearTimeout(timeoutId); } function after() { - clearTimeout(timeoutId); - timeoutId = setTimeout(heartbeat, settings.interval); + win.clearTimeout(timeoutId); + timeoutId = win.setTimeout(heartbeat, settings.interval); } function init() { diff --git a/src/_h5ai/public/js/lib/ext/contextmenu.js b/src/_h5ai/public/js/lib/ext/contextmenu.js index 4173b5a7..76f94e53 100644 --- a/src/_h5ai/public/js/lib/ext/contextmenu.js +++ b/src/_h5ai/public/js/lib/ext/contextmenu.js @@ -1,7 +1,8 @@ -const {document: doc, jQuery: jq, _: lo} = require('../win'); +const {win, jq, lo} = require('../globals'); const resource = require('../core/resource'); const allsettings = require('../core/settings'); +const doc = win.document; const settings = lo.extend({ enabled: false }, allsettings.contextmenu); diff --git a/src/_h5ai/public/js/lib/ext/crumb.js b/src/_h5ai/public/js/lib/ext/crumb.js index 6d7f2f6e..728d82b2 100644 --- a/src/_h5ai/public/js/lib/ext/crumb.js +++ b/src/_h5ai/public/js/lib/ext/crumb.js @@ -1,4 +1,4 @@ -const {jQuery: jq, _: lo} = require('../win'); +const {jq, lo} = require('../globals'); const event = require('../core/event'); const location = require('../core/location'); const resource = require('../core/resource'); diff --git a/src/_h5ai/public/js/lib/ext/custom.js b/src/_h5ai/public/js/lib/ext/custom.js index 7ffbfc2c..77d791bc 100644 --- a/src/_h5ai/public/js/lib/ext/custom.js +++ b/src/_h5ai/public/js/lib/ext/custom.js @@ -1,4 +1,4 @@ -const {jQuery: jq, _: lo, marked} = require('../win'); +const {jq, lo, marked} = require('../globals'); const event = require('../core/event'); const server = require('../core/server'); const allsettings = require('../core/settings'); diff --git a/src/_h5ai/public/js/lib/ext/download.js b/src/_h5ai/public/js/lib/ext/download.js index c91540a1..81b10eaa 100644 --- a/src/_h5ai/public/js/lib/ext/download.js +++ b/src/_h5ai/public/js/lib/ext/download.js @@ -1,4 +1,4 @@ -const {jQuery: jq, _: lo} = require('../win'); +const {jq, lo} = require('../globals'); const event = require('../core/event'); const location = require('../core/location'); const resource = require('../core/resource'); diff --git a/src/_h5ai/public/js/lib/ext/filter.js b/src/_h5ai/public/js/lib/ext/filter.js index 1af98e25..9c975d18 100644 --- a/src/_h5ai/public/js/lib/ext/filter.js +++ b/src/_h5ai/public/js/lib/ext/filter.js @@ -1,4 +1,4 @@ -const {jQuery: jq, _: lo} = require('../win'); +const {jq, lo} = require('../globals'); const event = require('../core/event'); const location = require('../core/location'); const resource = require('../core/resource'); diff --git a/src/_h5ai/public/js/lib/ext/google-analytics.js b/src/_h5ai/public/js/lib/ext/google-analytics.js index 52940884..8d838ebe 100644 --- a/src/_h5ai/public/js/lib/ext/google-analytics.js +++ b/src/_h5ai/public/js/lib/ext/google-analytics.js @@ -1,4 +1,4 @@ -const {window: win, _: lo} = require('../win'); +const {win, lo} = require('../globals'); const event = require('../core/event'); const allsettings = require('../core/settings'); diff --git a/src/_h5ai/public/js/lib/ext/info.js b/src/_h5ai/public/js/lib/ext/info.js index 18c1c8d6..419b3b46 100644 --- a/src/_h5ai/public/js/lib/ext/info.js +++ b/src/_h5ai/public/js/lib/ext/info.js @@ -1,4 +1,4 @@ -const {window: win, jQuery: jq, _: lo} = require('../win'); +const {win, jq, lo} = require('../globals'); const event = require('../core/event'); const format = require('../core/format'); const resource = require('../core/resource'); diff --git a/src/_h5ai/public/js/lib/ext/l10n.js b/src/_h5ai/public/js/lib/ext/l10n.js index 06322a8d..1a5604b8 100644 --- a/src/_h5ai/public/js/lib/ext/l10n.js +++ b/src/_h5ai/public/js/lib/ext/l10n.js @@ -1,4 +1,4 @@ -const {navigator, jQuery: jq, _: lo} = require('../win'); +const {win, jq, lo} = require('../globals'); const event = require('../core/event'); const format = require('../core/format'); const langs = require('../core/langs'); @@ -89,7 +89,7 @@ function localize(languages, isoCode, useBrowserLang) { if (languages[storedIsoCode]) { isoCode = storedIsoCode; } else if (useBrowserLang) { - const browserLang = navigator.language || navigator.browserLanguage; + const browserLang = win.navigator.language || win.navigator.browserLanguage; if (browserLang) { if (languages[browserLang]) { isoCode = browserLang; diff --git a/src/_h5ai/public/js/lib/ext/peer5.js b/src/_h5ai/public/js/lib/ext/peer5.js index 99c33b9a..323c2855 100644 --- a/src/_h5ai/public/js/lib/ext/peer5.js +++ b/src/_h5ai/public/js/lib/ext/peer5.js @@ -1,4 +1,4 @@ -const {window: win, jQuery: jq, _: lo} = require('../win'); +const {win, jq, lo} = require('../globals'); const allsettings = require('../core/settings'); const settings = lo.extend({ diff --git a/src/_h5ai/public/js/lib/ext/piwik-analytics.js b/src/_h5ai/public/js/lib/ext/piwik-analytics.js index 32bcb22f..2ad4e5ee 100644 --- a/src/_h5ai/public/js/lib/ext/piwik-analytics.js +++ b/src/_h5ai/public/js/lib/ext/piwik-analytics.js @@ -1,4 +1,4 @@ -const {window: win, jQuery: jq, _: lo} = require('../win'); +const {win, jq, lo} = require('../globals'); const event = require('../core/event'); const allsettings = require('../core/settings'); diff --git a/src/_h5ai/public/js/lib/ext/preview-aud.js b/src/_h5ai/public/js/lib/ext/preview-aud.js index 7ca9e7e7..564cdc51 100644 --- a/src/_h5ai/public/js/lib/ext/preview-aud.js +++ b/src/_h5ai/public/js/lib/ext/preview-aud.js @@ -1,4 +1,4 @@ -const {setTimeout, jQuery: jq, _: lo} = require('../win'); +const {win, jq, lo} = require('../globals'); const event = require('../core/event'); const format = require('../core/format'); const allsettings = require('../core/settings'); @@ -13,7 +13,7 @@ function preloadAudio(src, callback) { const $audio = jq('