Fix SwiftLinter warnings

Mist/MistApp.swift

@@ -10,7 +10,8 @@ import SwiftUI
 @main
 struct MistApp: App {
     // swiftlint:disable:next weak_delegate
-    @NSApplicationDelegateAdaptor(AppDelegate.self) var appDelegate: AppDelegate
+    @NSApplicationDelegateAdaptor(AppDelegate.self)
+    var appDelegate: AppDelegate
     @StateObject var sparkleUpdater: SparkleUpdater = SparkleUpdater()
     @State private var refreshing: Bool = false
     @State private var downloadInProgress: Bool = false

Mist/Views/ContentView.swift

@@ -8,8 +8,10 @@
 import SwiftUI
 
 struct ContentView: View {
-    @AppStorage("includeBetas") private var includeBetas: Bool = false
+    @AppStorage("includeBetas")
-    @AppStorage("showCompatible") private var showCompatible: Bool = false
+    private var includeBetas: Bool = false
+    @AppStorage("showCompatible")
+    private var showCompatible: Bool = false
     @Binding var refreshing: Bool
     @Binding var downloadInProgress: Bool
     @State private var downloadType: DownloadType = .firmware

Mist/Views/Download/DownloadView.swift

@@ -10,9 +10,12 @@ import SwiftUI
 
 struct DownloadView: View {
     // swiftlint:disable:next weak_delegate
-    @NSApplicationDelegateAdaptor(AppDelegate.self) var appDelegate: AppDelegate
+    @NSApplicationDelegateAdaptor(AppDelegate.self)
-    @Environment(\.presentationMode) var presentationMode: Binding<PresentationMode>
+    var appDelegate: AppDelegate
-    @AppStorage("enableNotifications") private var enableNotifications: Bool = false
+    @Environment(\.presentationMode)
+    var presentationMode: Binding<PresentationMode>
+    @AppStorage("enableNotifications")
+    private var enableNotifications: Bool = false
     var downloadType: DownloadType
     var imageName: String
     var name: String

Mist/Views/List/FirmwareListRow.swift

@@ -8,9 +8,12 @@
 import SwiftUI
 
 struct FirmwareListRow: View {
-    @AppStorage("firmwareFilename") private var firmwareFilename: String = .firmwareFilenameTemplate
+    @AppStorage("firmwareFilename")
-    @AppStorage("retries") private var retries: Int = 10
+    private var firmwareFilename: String = .firmwareFilenameTemplate
-    @AppStorage("retryDelay") private var retryDelay: Int = 30
+    @AppStorage("retries")
+    private var retries: Int = 10
+    @AppStorage("retryDelay")
+    private var retryDelay: Int = 30
     var firmware: Firmware
     @Binding var savePanel: NSSavePanel
     @Binding var downloadInProgress: Bool

Mist/Views/List/InstallerExportView.swift

@@ -8,10 +8,14 @@
 import SwiftUI
 
 struct InstallerExportView: View {
-    @AppStorage("exportApplication") private var exportApplication: Bool = true
+    @AppStorage("exportApplication")
-    @AppStorage("exportDiskImage") private var exportDiskImage: Bool = false
+    private var exportApplication: Bool = true
-    @AppStorage("exportISO") private var exportISO: Bool = false
+    @AppStorage("exportDiskImage")
-    @AppStorage("exportPackage") private var exportPackage: Bool = false
+    private var exportDiskImage: Bool = false
+    @AppStorage("exportISO")
+    private var exportISO: Bool = false
+    @AppStorage("exportPackage")
+    private var exportPackage: Bool = false
     @Binding var exports: [InstallerExportType]
 
     var body: some View {

Mist/Views/List/InstallerListRow.swift

@@ -8,19 +8,32 @@
 import SwiftUI
 
 struct InstallerListRow: View {
-    @AppStorage("cacheDownloads") private var cacheDownloads: Bool = false
+    @AppStorage("cacheDownloads")
-    @AppStorage("cacheDirectory") private var cacheDirectory: String = .cacheDirectory
+    private var cacheDownloads: Bool = false
-    @AppStorage("applicationFilename") private var applicationFilename: String = .applicationFilenameTemplate
+    @AppStorage("cacheDirectory")
-    @AppStorage("diskImageFilename") private var diskImageFilename: String = .diskImageFilenameTemplate
+    private var cacheDirectory: String = .cacheDirectory
-    @AppStorage("diskImageSign") private var diskImageSign: Bool = false
+    @AppStorage("applicationFilename")
-    @AppStorage("diskImageSigningIdentity") private var diskImageSigningIdentity: String = ""
+    private var applicationFilename: String = .applicationFilenameTemplate
-    @AppStorage("isoFilename") private var isoFilename: String = .isoFilenameTemplate
+    @AppStorage("diskImageFilename")
-    @AppStorage("packageFilename") private var packageFilename: String = .packageFilenameTemplate
+    private var diskImageFilename: String = .diskImageFilenameTemplate
-    @AppStorage("packageIdentifier") private var packageIdentifier: String = .packageIdentifierTemplate
+    @AppStorage("diskImageSign")
-    @AppStorage("packageSign") private var packageSign: Bool = false
+    private var diskImageSign: Bool = false
-    @AppStorage("packageSigningIdentity") private var packageSigningIdentity: String = ""
+    @AppStorage("diskImageSigningIdentity")
-    @AppStorage("retries") private var retries: Int = 10
+    private var diskImageSigningIdentity: String = ""
-    @AppStorage("retryDelay") private var retryDelay: Int = 30
+    @AppStorage("isoFilename")
+    private var isoFilename: String = .isoFilenameTemplate
+    @AppStorage("packageFilename")
+    private var packageFilename: String = .packageFilenameTemplate
+    @AppStorage("packageIdentifier")
+    private var packageIdentifier: String = .packageIdentifierTemplate
+    @AppStorage("packageSign")
+    private var packageSign: Bool = false
+    @AppStorage("packageSigningIdentity")
+    private var packageSigningIdentity: String = ""
+    @AppStorage("retries")
+    private var retries: Int = 10
+    @AppStorage("retryDelay")
+    private var retryDelay: Int = 30
     var installer: Installer
     @Binding var openPanel: NSOpenPanel
     @Binding var downloadInProgress: Bool

Mist/Views/List/ListRow.swift

@@ -22,8 +22,10 @@ struct ListRow: View {
     @ObservedObject var taskManager: TaskManager
     @State private var alertType: DownloadAlertType = .compatibility
     @State private var showAlert: Bool = false
-    @AppStorage("cacheDownloads") private var cacheDownloads: Bool = false
+    @AppStorage("cacheDownloads")
-    @AppStorage("cacheDirectory") private var cacheDirectory: String = .cacheDirectory
+    private var cacheDownloads: Bool = false
+    @AppStorage("cacheDirectory")
+    private var cacheDirectory: String = .cacheDirectory
     private let length: CGFloat = 48
     private let spacing: CGFloat = 5
     private let padding: CGFloat = 3

Mist/Views/Settings/SettingsApplicationsView.swift

@@ -18,7 +18,8 @@ struct SettingsApplicationsView: View {
         "Application - macOS High Sierra"
     ]
 
-    @AppStorage("applicationFilename") private var applicationFilename: String = .applicationFilenameTemplate
+    @AppStorage("applicationFilename")
+    private var applicationFilename: String = .applicationFilenameTemplate
     @State private var imageName: String = randomImageName()
     @State private var fade: Bool = false
     private let timer: Publishers.Autoconnect<Timer.TimerPublisher> = Timer.publish(every: 3, on: .main, in: .common).autoconnect()

Mist/Views/Settings/SettingsDiskImagesView.swift

@@ -8,9 +8,12 @@
 import SwiftUI
 
 struct SettingsDiskImagesView: View {
-    @AppStorage("diskImageFilename") private var diskImageFilename: String = .diskImageFilenameTemplate
+    @AppStorage("diskImageFilename")
-    @AppStorage("diskImageSign") private var diskImageSign: Bool = false
+    private var diskImageFilename: String = .diskImageFilenameTemplate
-    @AppStorage("diskImageSigningIdentity") private var diskImageSigningIdentity: String = ""
+    @AppStorage("diskImageSign")
+    private var diskImageSign: Bool = false
+    @AppStorage("diskImageSigningIdentity")
+    private var diskImageSigningIdentity: String = ""
     @State private var codesigningIdentities: [String] = ["Loading..."]
     private let diskImageSignDefault: Bool = false
     private let diskImageSigningIdentityDefault: String = ""

Mist/Views/Settings/SettingsFirmwaresView.swift

@@ -8,7 +8,8 @@
 import SwiftUI
 
 struct SettingsFirmwaresView: View {
-    @AppStorage("firmwareFilename") private var firmwareFilename: String = .firmwareFilenameTemplate
+    @AppStorage("firmwareFilename")
+    private var firmwareFilename: String = .firmwareFilenameTemplate
     private let imageName: String = "Firmware"
     private let title: String = "Firmwares"
     // swiftlint:disable:next line_length

Mist/Views/Settings/SettingsGeneralView.swift

@@ -8,11 +8,16 @@
 import SwiftUI
 
 struct SettingsGeneralView: View {
-    @AppStorage("enableNotifications") private var enableNotifications: Bool = false
+    @AppStorage("enableNotifications")
-    @AppStorage("retries") private var retries: Int = 10
+    private var enableNotifications: Bool = false
-    @AppStorage("retryDelay") private var retryDelay: Int = 30
+    @AppStorage("retries")
-    @AppStorage("SUEnableAutomaticChecks") private var enableAutomaticChecks: Bool = true
+    private var retries: Int = 10
-    @AppStorage("SUScheduledCheckInterval") private var scheduledCheckInterval: Int = 86_400
+    @AppStorage("retryDelay")
+    private var retryDelay: Int = 30
+    @AppStorage("SUEnableAutomaticChecks")
+    private var enableAutomaticChecks: Bool = true
+    @AppStorage("SUScheduledCheckInterval")
+    private var scheduledCheckInterval: Int = 86_400
     @ObservedObject var sparkleUpdater: SparkleUpdater
     private let enableNotificationsDefault: Bool = false
     private let retriesDefault: Int = 10

Mist/Views/Settings/SettingsISOsView.swift

@@ -8,7 +8,8 @@
 import SwiftUI
 
 struct SettingsISOsView: View {
-    @AppStorage("isoFilename") private var isoFilename: String = .isoFilenameTemplate
+    @AppStorage("isoFilename")
+    private var isoFilename: String = .isoFilenameTemplate
     private let imageName: String = "ISO"
     private let title: String = "ISOs"
     // swiftlint:disable:next line_length

Mist/Views/Settings/SettingsInstallersView.swift

@@ -8,8 +8,10 @@
 import SwiftUI
 
 struct SettingsInstallersView: View {
-    @AppStorage("cacheDownloads") private var cacheDownloads: Bool = false
+    @AppStorage("cacheDownloads")
-    @AppStorage("cacheDirectory") private var cacheDirectory: String = .cacheDirectory
+    private var cacheDownloads: Bool = false
+    @AppStorage("cacheDirectory")
+    private var cacheDirectory: String = .cacheDirectory
     @State private var catalogs: [Catalog] = []
     private let cacheDownloadsDefault: Bool = false
     private let cacheDirectoryDefault: String = .cacheDirectory

Mist/Views/Settings/SettingsPackagesView.swift

@@ -8,10 +8,14 @@
 import SwiftUI
 
 struct SettingsPackagesView: View {
-    @AppStorage("packageFilename") private var packageFilename: String = .packageFilenameTemplate
+    @AppStorage("packageFilename")
-    @AppStorage("packageIdentifier") private var packageIdentifier: String = .packageIdentifierTemplate
+    private var packageFilename: String = .packageFilenameTemplate
-    @AppStorage("packageSign") private var packageSign: Bool = false
+    @AppStorage("packageIdentifier")
-    @AppStorage("packageSigningIdentity") private var packageSigningIdentity: String = ""
+    private var packageIdentifier: String = .packageIdentifierTemplate
+    @AppStorage("packageSign")
+    private var packageSign: Bool = false
+    @AppStorage("packageSigningIdentity")
+    private var packageSigningIdentity: String = ""
     @State private var codesigningIdentities: [String] = ["Loading..."]
     private let packageSignDefault: Bool = false
     private let packageSigningIdentityDefault: String = ""