mirrors/Mist
1
0
Fork 0
mirror of https://github.com/ninxsoft/Mist.git synced 2025-05-13 22:54:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor Linter warnings

Browse source
This commit is contained in:
Nindi Gill 2022-12-08 11:40:00 +11:00
parent 1688095e18
commit a2b3412b14
4 changed files with 14 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Mist/Helpers/DownloadManager.swift
View file

@ -16,6 +16,7 @@ class DownloadManager: NSObject, ObservableObject {
progress.fractionCompleted progress.fractionCompleted
} }
// swiftlint:disable:next cyclomatic_complexity function_body_length
func download(_ url: URL, to destination: URL, retries retriesMaximum: Int, delay retryDelay: Int) async throws { func download(_ url: URL, to destination: URL, retries retriesMaximum: Int, delay retryDelay: Int) async throws {
guard !FileManager.default.fileExists(atPath: destination.path) else { guard !FileManager.default.fileExists(atPath: destination.path) else {
@ -27,6 +28,7 @@ class DownloadManager: NSObject, ObservableObject {
var urlError: URLError? var urlError: URLError?
var retries: Int = 0 var retries: Int = 0
var completed: Bool = false var completed: Bool = false
// swiftlint:disable:next closure_body_length
let completionHandler: (URL?, URLResponse?, Error?) -> Void = { url, _, error in let completionHandler: (URL?, URLResponse?, Error?) -> Void = { url, _, error in
if let error: URLError = error as? URLError { if let error: URLError = error as? URLError {

20
Mist/Helpers/TaskManager.swift
View file

@ -87,8 +87,7 @@ class TaskManager: ObservableObject {
] ]
} }
// swiftlint:disable function_parameter_count // swiftlint:disable:next function_parameter_count
private static func firmwareDownloadTasks( private static func firmwareDownloadTasks(
firmware: Firmware, firmware: Firmware,
firmwareURL: URL, firmwareURL: URL,
@ -120,8 +119,6 @@ class TaskManager: ObservableObject {
return tasks return tasks
} }
// swiftlint:enable function_parameter_count
private static func firmwareCleanupTasks(temporaryDirectory temporaryDirectoryURL: URL) -> [MistTask] { private static func firmwareCleanupTasks(temporaryDirectory temporaryDirectoryURL: URL) -> [MistTask] {
[ [
MistTask(type: .remove, description: "temporary directory") { MistTask(type: .remove, description: "temporary directory") {
@ -130,8 +127,7 @@ class TaskManager: ObservableObject {
] ]
} }
// swiftlint:disable function_parameter_count // swiftlint:disable:next function_parameter_count
static func taskGroups( static func taskGroups(
for installer: Installer, for installer: Installer,
destination destinationURL: URL?, destination destinationURL: URL?,
@ -225,8 +221,6 @@ class TaskManager: ObservableObject {
return taskGroups return taskGroups
} }
// swiftlint:enable function_parameter_count
private static func downloadTasks(for installer: Installer, cacheDirectory cacheDirectoryURL: URL, retries: Int, delay retryDelay: Int) throws -> [MistTask] { private static func downloadTasks(for installer: Installer, cacheDirectory cacheDirectoryURL: URL, retries: Int, delay retryDelay: Int) throws -> [MistTask] {
var tasks: [MistTask] = [] var tasks: [MistTask] = []
@ -292,8 +286,7 @@ class TaskManager: ObservableObject {
] ]
} }
// swiftlint:disable function_parameter_count // swiftlint:disable:next function_parameter_count
private static func diskImageTasks( private static func diskImageTasks(
for installer: Installer, for installer: Installer,
filename: String, filename: String,
@ -338,8 +331,6 @@ class TaskManager: ObservableObject {
return tasks return tasks
} }
// swiftlint:enable function_parameter_count
private static func isoTasks(for installer: Installer, filename: String, destination destinationURL: URL, temporaryDirectory temporaryDirectoryURL: URL) -> [MistTask] { private static func isoTasks(for installer: Installer, filename: String, destination destinationURL: URL, temporaryDirectory temporaryDirectoryURL: URL) -> [MistTask] {
let temporaryImageURL: URL = temporaryDirectoryURL.appendingPathComponent("\(installer.id).dmg") let temporaryImageURL: URL = temporaryDirectoryURL.appendingPathComponent("\(installer.id).dmg")
@ -369,8 +360,7 @@ class TaskManager: ObservableObject {
] ]
} }
// swiftlint:disable function_parameter_count // swiftlint:disable:next function_parameter_count
private static func packageTasks( private static func packageTasks(
for installer: Installer, for installer: Installer,
filename: String, filename: String,
@ -411,8 +401,6 @@ class TaskManager: ObservableObject {
return tasks return tasks
} }
// swiftlint:enable function_parameter_count
private static func cleanupTasks(mountPoint mountPointURL: URL, temporaryDirectory temporaryDirectoryURL: URL, cacheDownloads: Bool, cacheDirectory cacheDirectoryURL: URL) -> [MistTask] { private static func cleanupTasks(mountPoint mountPointURL: URL, temporaryDirectory temporaryDirectoryURL: URL, cacheDownloads: Bool, cacheDirectory cacheDirectoryURL: URL) -> [MistTask] {
var tasks: [MistTask] = [ var tasks: [MistTask] = [

5
Mist/Model/ExportListType.swift
View file

@ -9,10 +9,13 @@ import Foundation
import UniformTypeIdentifiers import UniformTypeIdentifiers
enum ExportListType: String, CaseIterable, Identifiable { enum ExportListType: String, CaseIterable, Identifiable {
// swiftlint:disable redundant_string_enum_value // swiftlint:disable:next redundant_string_enum_value
case csv = "csv" case csv = "csv"
// swiftlint:disable:next redundant_string_enum_value
case json = "json" case json = "json"
// swiftlint:disable:next redundant_string_enum_value
case plist = "plist" case plist = "plist"
// swiftlint:disable:next redundant_string_enum_value
case yaml = "yaml" case yaml = "yaml"
var id: String { var id: String {

5
Shared/HelperToolCommandType.swift
View file

@ -8,9 +8,12 @@
import Foundation import Foundation
enum HelperToolCommandType: String, Codable { enum HelperToolCommandType: String, Codable {
// swiftlint:disable redundant_string_enum_value // swiftlint:disable:next redundant_string_enum_value
case remove = "remove" case remove = "remove"
// swiftlint:disable:next redundant_string_enum_value
case installer = "installer" case installer = "installer"
// swiftlint:disable:next redundant_string_enum_value
case createinstallmedia = "createinstallmedia" case createinstallmedia = "createinstallmedia"
// swiftlint:disable:next redundant_string_enum_value
case kill = "kill" case kill = "kill"
} }