mirrors/DiscordChatExporter
1
0
Fork 0
mirror of https://github.com/Tyrrrz/DiscordChatExporter.git synced 2025-05-24 03:36:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[CLI] Fix missing channel category bug when API returns empty string (#492)

Browse source
This commit is contained in:
Frederic Portaria-Janicki 2021-02-02 07:42:04 -05:00 • committed by GitHub
parent 8b9afe45b9
commit e49cf997ea
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
DiscordChatExporter.Domain/Discord/DiscordClient.cs
View file

@ -171,9 +171,20 @@ namespace DiscordChatExporter.Domain.Discord
public async ValueTask<ChannelCategory> GetChannelCategoryAsync(Snowflake channelId) public async ValueTask<ChannelCategory> GetChannelCategoryAsync(Snowflake channelId)
{ {
var response = await GetJsonResponseAsync($"channels/{channelId}"); try
{
var response = await GetJsonResponseAsync($"channels/{channelId}");
return ChannelCategory.Parse(response);
}
/***
* In some cases, the Discord API returns an empty body when requesting some channel category info.
* Instead, we use an empty channel category as a fallback.
*/
catch (DiscordChatExporterException)
{
return ChannelCategory.Empty;
}
return ChannelCategory.Parse(response);
} }
public async ValueTask<Channel> GetChannelAsync(Snowflake channelId) public async ValueTask<Channel> GetChannelAsync(Snowflake channelId)

4
DiscordChatExporter.Domain/Discord/Models/ChannelCategory.cs
View file

@ -44,5 +44,7 @@ namespace DiscordChatExporter.Domain.Discord.Models
position.Value position.Value
); );
} }
public static ChannelCategory Empty { get; } = new(Snowflake.Zero, "Missing", 0);
} }
} }