mirrors/DiscordChatExporter
1
0
Fork 0
mirror of https://github.com/Tyrrrz/DiscordChatExporter.git synced 2025-05-15 23:54:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Skip Twitch clip projections because they can't be rendered locally (#1200)

Browse source
This commit is contained in:
Oleksii Holub 2024-02-13 18:59:51 +02:00 • committed by GitHub
parent 4588bd0496
commit 7c04db40f8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
DiscordChatExporter.Cli.Tests/Specs/HtmlEmbedSpecs.cs
View file

@ -150,7 +150,7 @@ public class HtmlEmbedSpecs
iframeUrl.Should().StartWith("https://open.spotify.com/embed/track/1LHZMWefF9502NPfArRfvP"); iframeUrl.Should().StartWith("https://open.spotify.com/embed/track/1LHZMWefF9502NPfArRfvP");
} }
[Fact] [Fact(Skip = "Twitch does not allow embeds from inside local HTML files")]
public async Task I_can_export_a_channel_that_contains_a_message_with_a_Twitch_clip_embed() public async Task I_can_export_a_channel_that_contains_a_message_with_a_Twitch_clip_embed()
{ {
// https://github.com/Tyrrrz/DiscordChatExporter/issues/1196 // https://github.com/Tyrrrz/DiscordChatExporter/issues/1196

14
DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml
View file

@ -365,15 +365,6 @@
</div> </div>
</div> </div>
} }
// Twitch embed
else if (embed.TryGetTwitchClip() is { } twitchClipEmbed)
{
<div class="chatlog__embed">
<div class="chatlog__embed-twitch-container">
<iframe class="chatlog__embed-twitch" src="@twitchClipEmbed.Url" width="400" height="225"></iframe>
</div>
</div>
}
// YouTube embed // YouTube embed
else if (embed.TryGetYouTubeVideo() is { } youTubeVideoEmbed) else if (embed.TryGetYouTubeVideo() is { } youTubeVideoEmbed)
{ {
@ -457,7 +448,10 @@
</div> </div>
} }
// Generic video embed // Generic video embed
else if (embed.Kind == EmbedKind.Video && !string.IsNullOrWhiteSpace(embed.Url)) else if (embed.Kind == EmbedKind.Video
&& !string.IsNullOrWhiteSpace(embed.Url)
// Twitch clips cannot be embedded in local HTML files
&& embed.TryGetTwitchClip() is null)
{ {
var embedVideoUrl = var embedVideoUrl =
embed.Video?.ProxyUrl ?? embed.Video?.Url ?? embed.Video?.ProxyUrl ?? embed.Video?.Url ??