Use "final" and "override" where appropriate (#117)

stratosphere/pm/source/pm_boot_mode.hpp

@@ -7,13 +7,13 @@ enum BootModeCmd {
     BootMode_Cmd_SetMaintenanceBoot = 1
 };
 
-class BootModeService : IServiceObject {
+class BootModeService final : IServiceObject, public IpcCommandWrapper<BootModeService> {
     public:
-        virtual Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size);
-        virtual Result handle_deferred();
+        Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size) override;
+        Result handle_deferred() override;
         
     private:
         /* Actual commands. */
         std::tuple<Result, bool> get_boot_mode();
         std::tuple<Result> set_maintenance_boot();
-};
+};

stratosphere/pm/source/pm_debug_monitor.hpp

@@ -23,10 +23,10 @@ enum DmntCmd_5X {
     Dmnt_Cmd_5X_EnableDebugForApplication = 5,
 };
 
-class DebugMonitorService : IServiceObject {
+class DebugMonitorService final : IServiceObject {
     public:
-        virtual Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size);
-        virtual Result handle_deferred();
+        Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size) override;
+        Result handle_deferred() override;
         
     private:
         /* Actual commands. */
@@ -37,4 +37,4 @@ class DebugMonitorService : IServiceObject {
         std::tuple<Result, CopiedHandle> enable_debug_for_tid(u64 tid);
         std::tuple<Result, u64> get_application_process_id();
         std::tuple<Result, CopiedHandle> enable_debug_for_application();
-};
+};

stratosphere/pm/source/pm_info.hpp

@@ -6,12 +6,12 @@ enum InformationCmd {
     Information_Cmd_GetTitleId = 0,
 };
 
-class InformationService : IServiceObject {
+class InformationService final : IServiceObject {
     public:
-        virtual Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size);
-        virtual Result handle_deferred();
+        Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size) override;
+        Result handle_deferred() override;
         
     private:
         /* Actual commands. */
         std::tuple<Result, u64> get_title_id(u64 pid);
-};
+};

stratosphere/pm/source/pm_process_wait.hpp

@@ -2,7 +2,7 @@
 #include <switch.h>
 #include <stratosphere.hpp>
 
-class ProcessWaiter : public IWaitable {
+class ProcessWaiter final : public IWaitable {
     public:
         Registration::Process process;
         
@@ -19,33 +19,33 @@ class ProcessWaiter : public IWaitable {
         }
         
         /* IWaitable */
-        virtual unsigned int get_num_waitables() {
+        unsigned int get_num_waitables() override {
             return 1;
         }
         
-        virtual void get_waitables(IWaitable **dst) {
+        void get_waitables(IWaitable **dst) override {
             dst[0] = this;
         }
         
-        virtual void delete_child(IWaitable *child) {
+        void delete_child(IWaitable *child) override {
             /* TODO: Panic, because we can never have any children. */
         }
         
-        virtual Handle get_handle() {
+        Handle get_handle() override {
             return this->process.handle;
         }
         
-        virtual void handle_deferred() {
+        void handle_deferred() override {
             /* TODO: Panic, because we can never be deferred. */
         }
         
-        virtual Result handle_signaled(u64 timeout) {
+        Result handle_signaled(u64 timeout) override {
             Registration::HandleSignaledProcess(this->get_process());
             return 0;
         }
 };
 
-class ProcessList : public IWaitable {
+class ProcessList final : public IWaitable {
     private:      
         HosRecursiveMutex mutex;
     public:
@@ -64,11 +64,11 @@ class ProcessList : public IWaitable {
         }
         
         /* IWaitable */
-        virtual unsigned int get_num_waitables() {
+        unsigned int get_num_waitables() override {
             return process_waiters.size();
         }
         
-        virtual void get_waitables(IWaitable **dst) {
+        void get_waitables(IWaitable **dst) override {
             Lock();
             for (unsigned int i = 0; i < process_waiters.size(); i++) {
                 dst[i] = process_waiters[i];
@@ -76,20 +76,20 @@ class ProcessList : public IWaitable {
             Unlock();
         }
         
-        virtual void delete_child(IWaitable *child) {
+        void delete_child(IWaitable *child) override {
             /* TODO: Panic, because we should never be asked to delete a child. */
         }
         
-        virtual Handle get_handle() {
+        Handle get_handle() override {
             /* TODO: Panic, because we don't have a handle. */
             return 0;
         }
         
-        virtual void handle_deferred() {
+        void handle_deferred() override {
             /* TODO: Panic, because we can never be deferred. */
         }
         
-        virtual Result handle_signaled(u64 timeout) {
+        Result handle_signaled(u64 timeout) override {
             /* TODO: Panic, because we can never be signaled. */         
             return 0;
         }

stratosphere/pm/source/pm_shell.hpp

@@ -30,10 +30,10 @@ enum ShellCmd_5X {
     Shell_Cmd_5X_BoostSystemMemoryResourceLimit = 7
 };
 
-class ShellService : IServiceObject {
+class ShellService final : IServiceObject {
     public:
-        virtual Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size);
-        virtual Result handle_deferred();
+        Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size) override;
+        Result handle_deferred() override;
         
     private:
         /* Actual commands. */
@@ -47,4 +47,4 @@ class ShellService : IServiceObject {
         std::tuple<Result> notify_boot_finished();
         std::tuple<Result, u64> get_application_process_id();
         std::tuple<Result> boost_system_memory_resource_limit(u64 sysmem_size);
-};
+};