libstrat: enable -Wextra, -Werror

This caught an embarrassingly large number of bugs.
This commit is contained in:
Michael Scire 2021-10-06 15:20:48 -07:00
parent e1fbf27398
commit 7ca83c9d3b
160 changed files with 691 additions and 152 deletions

View file

@ -150,6 +150,7 @@ namespace ams::pgl::srv {
}
void Deallocate(void *p, size_t size) {
AMS_UNUSED(size);
return lmem::FreeToExpHeap(GetHeapHandle(), p);
}
@ -168,7 +169,7 @@ namespace ams::pgl::srv {
/* Start the Process Tracking thread. */
pgl::srv::InitializeProcessControlTask();
/* TODO: Loop process. */
/* Loop process. */
LoopProcessServer();
}

View file

@ -186,6 +186,8 @@ namespace ams::pgl::srv {
}
Result GetContentPathInNspd(lr::Path *out, ncm::ContentType type, util::optional<u8> index) const {
AMS_UNUSED(index);
/* Get the content name. */
const char *content_name = nullptr;
switch (type) {

View file

@ -30,10 +30,12 @@ namespace ams::pgl::srv {
}
Result ShellInterfaceCommon::LaunchProgramFromHostImpl(os::ProcessId *out, const void *content_path, size_t content_path_size, u32 pm_flags) {
AMS_UNUSED(content_path_size);
return pgl::srv::LaunchProgramFromHost(out, static_cast<const char *>(content_path), pm_flags);
}
Result ShellInterfaceCommon::GetHostContentMetaInfoImpl(pgl::ContentMetaInfo *out, const void *content_path, size_t content_path_size) {
AMS_UNUSED(content_path_size);
return pgl::srv::GetHostContentMetaInfo(out, static_cast<const char *>(content_path));
}
@ -66,6 +68,7 @@ namespace ams::pgl::srv {
}
Result ShellInterfaceCommon::TriggerApplicationSnapShotDumperImpl(SnapShotDumpType dump_type, const void *arg, size_t arg_size) {
AMS_UNUSED(arg_size);
return pgl::srv::TriggerApplicationSnapShotDumper(dump_type, static_cast<const char *>(arg));
}
@ -123,6 +126,7 @@ namespace ams::pgl::srv {
}
Result ShellInterfaceCmif::Command21NotImplemented(ams::sf::Out<u64> out, u32 in, const ams::sf::InBuffer &buf1, const ams::sf::InBuffer &buf2) {
AMS_UNUSED(out, in, buf1, buf2);
return pgl::ResultNotImplemented();
}