mirrors/Atmosphere
1
0
Fork 0
mirror of https://github.com/Atmosphere-NX/Atmosphere.git synced 2025-05-21 10:25:08 -04:00
Code Issues Projects Releases Packages Wiki Activity

ldr: address review commentary.

Browse source
This commit is contained in:
Michael Scire 2019-06-27 17:37:33 -07:00
parent 61fcf5e0f4
commit 6ba2090c01
8 changed files with 129 additions and 156 deletions
Download patch file Download diff file Expand all files Collapse all files

12
stratosphere/loader/source/ldr_arguments.cpp
View file

@ -28,7 +28,7 @@ namespace sts::ldr::args {
ArgumentInfo g_argument_infos[MaxArgumentInfos];
/* Helpers. */
ArgumentInfo *GetArgumentInfo(ncm::TitleId title_id) {
ArgumentInfo *FindArgumentInfo(ncm::TitleId title_id) {
for (size_t i = 0; i < MaxArgumentInfos; i++) {
if (g_argument_infos[i].title_id == title_id) {
return &g_argument_infos[i];
@ -37,15 +37,15 @@ namespace sts::ldr::args {
return nullptr;
}
ArgumentInfo *GetFreeArgumentInfo() {
return GetArgumentInfo(FreeTitleId);
ArgumentInfo *FindFreeArgumentInfo() {
return FindArgumentInfo(FreeTitleId);
}
}
/* API. */
const ArgumentInfo *Get(ncm::TitleId title_id) {
return GetArgumentInfo(title_id);
return FindArgumentInfo(title_id);
}
Result Set(ncm::TitleId title_id, const void *args, size_t args_size) {
@ -53,9 +53,9 @@ namespace sts::ldr::args {
return ResultLoaderTooLongArgument;
}
ArgumentInfo *arg_info = GetArgumentInfo(title_id);
ArgumentInfo *arg_info = FindArgumentInfo(title_id);
if (arg_info == nullptr) {
arg_info = GetFreeArgumentInfo();
arg_info = FindFreeArgumentInfo();
}
if (arg_info == nullptr) {
return ResultLoaderTooManyArguments;