diff --git a/archivebox/abid_utils/models.py b/archivebox/abid_utils/models.py index de8b3c87..07fd3b3a 100644 --- a/archivebox/abid_utils/models.py +++ b/archivebox/abid_utils/models.py @@ -69,8 +69,8 @@ class ABIDModel(models.Model): abid_subtype_src = 'None' # e.g. 'self.extractor' abid_rand_src = 'None' # e.g. 'self.uuid' or 'self.id' - id = models.UUIDField(primary_key=True, default=uuid4, editable=True) - uuid = models.UUIDField(blank=True, null=True, editable=True, unique=True) + # id = models.UUIDField(primary_key=True, default=uuid4, editable=True) + # uuid = models.UUIDField(blank=True, null=True, editable=True, unique=True) abid = ABIDField(prefix=abid_prefix) created_by = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.CASCADE, default=get_or_create_system_user_pk) diff --git a/archivebox/core/admin.py b/archivebox/core/admin.py index 3fa86816..cc773f78 100644 --- a/archivebox/core/admin.py +++ b/archivebox/core/admin.py @@ -185,8 +185,8 @@ def get_abid_info(self, obj): ''', obj.pk, - obj.id, - obj.uuid, + getattr(obj, 'id', str(getattr(obj, 'old_id', '')) + ' (.old_id)'), + getattr(obj, 'uuid', str(getattr(obj, 'id', '')) +' (.id)'), *obj.abid.split('_', 1), obj.api_url, obj.api_docs_url, obj.ABID.ts, obj.abid_values['ts'].isoformat() if isinstance(obj.abid_values['ts'], datetime) else obj.abid_values['ts'], obj.ABID.uri, str(obj.abid_values['uri']), @@ -204,8 +204,8 @@ class SnapshotAdmin(SearchResultsAdminMixin, admin.ModelAdmin): sort_fields = ('title_str', 'url_str', 'added', 'files') readonly_fields = ('admin_actions', 'status_info', 'bookmarked', 'added', 'updated', 'created', 'modified', 'identifiers') search_fields = ('id', 'url', 'abid', 'uuid', 'timestamp', 'title', 'tags__name') - fields = ('url', 'timestamp', 'created_by', 'tags', 'title', *readonly_fields) list_filter = ('added', 'updated', 'tags', 'archiveresult__status', 'created_by') + fields = ('url', 'timestamp', 'created_by', 'tags', 'title', *readonly_fields) ordering = ['-added'] actions = ['add_tags', 'remove_tags', 'update_titles', 'update_snapshots', 'resnapshot_snapshot', 'overwrite_snapshots', 'delete_snapshots'] autocomplete_fields = ['tags'] diff --git a/archivebox/core/models.py b/archivebox/core/models.py index dfd826f2..3f496bcc 100644 --- a/archivebox/core/models.py +++ b/archivebox/core/models.py @@ -5,6 +5,7 @@ from typing import Optional, List, Dict from django_stubs_ext.db.models import TypedModelMeta import json +import random import uuid from uuid import uuid4 @@ -60,7 +61,7 @@ class Tag(ABIDModel): # id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=True) id = models.AutoField(primary_key=True, serialize=False, verbose_name='ID') - uuid = models.UUIDField(blank=True, null=True, editable=True, unique=True) + uuid = models.UUIDField(default=uuid.uuid4, editable=True, unique=True) abid = ABIDField(prefix=abid_prefix) @@ -122,7 +123,7 @@ class Snapshot(ABIDModel): abid_rand_src = 'self.id' id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=False) # legacy pk - uuid = models.UUIDField(blank=True, null=True, editable=True, unique=True) + uuid = models.UUIDField(default=uuid.uuid4, editable=True, unique=True) abid = ABIDField(prefix=abid_prefix) url = models.URLField(unique=True, db_index=True) @@ -335,18 +336,19 @@ class ArchiveResultManager(models.Manager): qs = qs.annotate(indexing_precedence=Case(*precedence, default=Value(1000),output_field=IntegerField())).order_by('indexing_precedence') return qs +def rand_int_id(): + return random.getrandbits(32) class ArchiveResult(ABIDModel): abid_prefix = 'res_' abid_ts_src = 'self.snapshot.added' abid_uri_src = 'self.snapshot.url' abid_subtype_src = 'self.extractor' - abid_rand_src = 'self.uuid' + abid_rand_src = 'self.id' EXTRACTOR_CHOICES = EXTRACTOR_CHOICES - id = models.AutoField(primary_key=True, serialize=False, verbose_name='ID') # legacy pk TODO: move to UUIDField - # id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=False) - uuid = models.UUIDField(blank=True, null=True, editable=True, unique=True) + old_id = models.BigIntegerField(default=rand_int_id, serialize=False, verbose_name='ID') + id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=True, unique=True) abid = ABIDField(prefix=abid_prefix) snapshot = models.ForeignKey(Snapshot, on_delete=models.CASCADE) @@ -363,10 +365,15 @@ class ArchiveResult(ABIDModel): class Meta(TypedModelMeta): verbose_name = 'Result' + def __str__(self): return self.extractor + def save(self, *args, **kwargs): + super().save(*args, **kwargs) + assert str(self.id) == str(self.abid.uuid) + @cached_property def snapshot_dir(self): return Path(self.snapshot.link_dir)