From c9b3bab84d41aa8e789436130c8cf1f3df06e4b8 Mon Sep 17 00:00:00 2001 From: Nick Sweeting Date: Tue, 18 Aug 2020 08:49:26 -0400 Subject: [PATCH] fix pull title not working --- archivebox/core/admin.py | 2 +- archivebox/extractors/__init__.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/archivebox/core/admin.py b/archivebox/core/admin.py index 941cedab..97bce1a5 100644 --- a/archivebox/core/admin.py +++ b/archivebox/core/admin.py @@ -33,7 +33,7 @@ def update_titles(modeladmin, request, queryset): archive_links([ snapshot.as_link() for snapshot in queryset - ], overwrite=True, methods=('title',), out_dir=OUTPUT_DIR) + ], overwrite=True, methods=('title','favicon'), out_dir=OUTPUT_DIR) update_titles.short_description = "Pull title" def overwrite_snapshots(modeladmin, request, queryset): diff --git a/archivebox/extractors/__init__.py b/archivebox/extractors/__init__.py index b730aa54..ab80716a 100644 --- a/archivebox/extractors/__init__.py +++ b/archivebox/extractors/__init__.py @@ -63,10 +63,10 @@ def archive_link(link: Link, overwrite: bool=False, methods: Optional[Iterable[s ARCHIVE_METHODS = get_default_archive_methods() - if methods is not None: + if methods: ARCHIVE_METHODS = [ method for method in ARCHIVE_METHODS - if method[1] in methods + if method[0] in methods ] out_dir = out_dir or link.link_dir