mirrors/ArchiveBox
1
0
Fork 0
mirror of https://github.com/ArchiveBox/ArchiveBox.git synced 2025-05-13 06:34:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix CHROME_TIMEOUT causing hanging on some platforms

Browse source
This commit is contained in:
Nick Sweeting 2024-10-04 21:49:09 -07:00
parent ac96cc62fc
commit beefe69b74
No known key found for this signature in database
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
archivebox/plugins_extractor/chrome/apps.py
View file

@ -185,12 +185,13 @@ class ChromeConfig(BaseConfigSet):
if options.CHROME_USER_AGENT: if options.CHROME_USER_AGENT:
cmd_args += ('--user-agent={}'.format(options.CHROME_USER_AGENT),) cmd_args += ('--user-agent={}'.format(options.CHROME_USER_AGENT),)
if options.CHROME_TIMEOUT: # this no longer works on newer chrome version for some reason, just causes chrome to hang indefinitely:
cmd_args += ('--timeout={}'.format(options.CHROME_TIMEOUT * 1000),) # if options.CHROME_TIMEOUT:
# cmd_args += ('--timeout={}'.format(options.CHROME_TIMEOUT * 1000),)
if options.CHROME_USER_DATA_DIR: if options.CHROME_USER_DATA_DIR:
cmd_args.append('--user-data-dir={}'.format(options.CHROME_USER_DATA_DIR)) cmd_args.append('--user-data-dir={}'.format(options.CHROME_USER_DATA_DIR))
cmd_args.append('--profile-directory={}'.format(options.CHROME_PROFILE_NAME)) cmd_args.append('--profile-directory={}'.format(options.CHROME_PROFILE_NAME or 'Default'))
return dedupe(cmd_args) return dedupe(cmd_args)