mirrors/ArchiveBox
1
0
Fork 0
mirror of https://github.com/ArchiveBox/ArchiveBox.git synced 2025-05-23 03:06:55 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor should_save_extractor methods to accept overwrite parameter

Browse source
This commit is contained in:
Dan Arnfield 2021-01-21 15:45:11 -06:00
parent 553c3ca219
commit 5420903102
14 changed files with 56 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

8
archivebox/extractors/favicon.py
View file

@ -20,13 +20,13 @@ from ..logging_util import TimedProgress
@enforce_types
def should_save_favicon(link: Link, out_dir: Optional[str]=None) -> bool:
out_dir = out_dir or link.link_dir
if (Path(out_dir) / 'favicon.ico').exists():
def should_save_favicon(link: Link, out_dir: Optional[str]=None, overwrite: Optional[bool]=False) -> bool:
out_dir = out_dir or Path(link.link_dir)
if not overwrite and (out_dir / 'favicon.ico').exists():
return False
return SAVE_FAVICON
@enforce_types
def save_favicon(link: Link, out_dir: Optional[Path]=None, timeout: int=TIMEOUT) -> ArchiveResult:
"""download site favicon from google's favicon api"""