From 45736036e01449346e2264e368f076eab29cd06b Mon Sep 17 00:00:00 2001
From: Nick Sweeting <github@sweeting.me>
Date: Thu, 26 Sep 2024 02:36:59 -0700
Subject: [PATCH] simplify archivebox.constants to just use benedict instead of
 kludgy NamedTuple

---
 archivebox/constants.py | 451 ++++++++++++++++++++--------------------
 1 file changed, 222 insertions(+), 229 deletions(-)

diff --git a/archivebox/constants.py b/archivebox/constants.py
index 295a8f28..a88086b0 100644
--- a/archivebox/constants.py
+++ b/archivebox/constants.py
@@ -2,8 +2,8 @@ __package__ = 'archivebox'
 
 
 import os
-from types import MappingProxyType
-from typing import Set, Dict, NamedTuple, Tuple
+import re
+from typing import Dict
 from pathlib import Path
 
 from benedict import benedict
@@ -14,236 +14,229 @@ from .misc.logging import DEFAULT_CLI_COLORS
 
 ###################### Config ##########################
 
-class ConstantsConfig(NamedTuple):
-    
-    VERSION: str = archivebox.__version__
-    
-    DEFAULT_CLI_COLORS: Dict[str, str]        = DEFAULT_CLI_COLORS
-    DISABLED_CLI_COLORS: Dict[str, str]       = benedict({k: '' for k in DEFAULT_CLI_COLORS})
-    
-    PACKAGE_DIR: Path = archivebox.PACKAGE_DIR
-    PACKAGE_DIR_NAME: str = archivebox.PACKAGE_DIR.name
-    TEMPLATES_DIR_NAME: str = 'templates'
-    TEMPLATES_DIR: Path                 = archivebox.PACKAGE_DIR / TEMPLATES_DIR_NAME
-    STATIC_DIR: Path                    = TEMPLATES_DIR / 'static'
-    USER_PLUGINS_DIR_NAME: str          = 'user_plugins'
-    CUSTOM_TEMPLATES_DIR_NAME: str      = 'user_templates'
-    
-    DATA_DIR: Path = archivebox.DATA_DIR
-    ARCHIVE_DIR_NAME: str = 'archive'
-    SOURCES_DIR_NAME: str = 'sources'
-    PERSONAS_DIR_NAME: str = 'personas'
-    CRONTABS_DIR_NAME: str = 'crontabs'
-    CACHE_DIR_NAME: str = 'cache'
-    LOGS_DIR_NAME: str = 'logs'
-    LIB_DIR_NAME: str = 'lib'
-    TMP_DIR_NAME: str = 'tmp'
-    OUTPUT_DIR: Path                    = archivebox.DATA_DIR
-    ARCHIVE_DIR: Path                   = archivebox.DATA_DIR / ARCHIVE_DIR_NAME
-    SOURCES_DIR: Path                   = archivebox.DATA_DIR / SOURCES_DIR_NAME
-    PERSONAS_DIR: Path                  = archivebox.DATA_DIR / PERSONAS_DIR_NAME
-    CACHE_DIR: Path                     = archivebox.DATA_DIR / CACHE_DIR_NAME
-    LOGS_DIR: Path                      = archivebox.DATA_DIR / LOGS_DIR_NAME
-    LIB_DIR: Path                       = archivebox.DATA_DIR / LIB_DIR_NAME
-    TMP_DIR: Path                       = archivebox.DATA_DIR / TMP_DIR_NAME
-    CUSTOM_TEMPLATES_DIR: Path          = archivebox.DATA_DIR / CUSTOM_TEMPLATES_DIR_NAME
-    USER_PLUGINS_DIR: Path              = archivebox.DATA_DIR / USER_PLUGINS_DIR_NAME
-    
-    LIB_PIP_DIR: Path                   = LIB_DIR / 'pip'
-    LIB_NPM_DIR: Path                   = LIB_DIR / 'npm'
-    LIB_BROWSERS_DIR: Path              = LIB_DIR / 'browsers'
-    LIB_BIN_DIR: Path                   = LIB_DIR / 'bin'
-    BIN_DIR: Path                       = LIB_BIN_DIR
-    
-    CONFIG_FILENAME: str = 'ArchiveBox.conf'
-    SQL_INDEX_FILENAME: str = 'index.sqlite3'
-    
-    CONFIG_FILE: Path                   = archivebox.DATA_DIR / CONFIG_FILENAME
-    DATABASE_FILE: Path                 = archivebox.DATA_DIR / SQL_INDEX_FILENAME
-    QUEUE_DATABASE_FILE: Path           = archivebox.DATA_DIR / SQL_INDEX_FILENAME.replace('index.', 'queue.')
-    
-    JSON_INDEX_FILENAME: str = 'index.json'
-    HTML_INDEX_FILENAME: str = 'index.html'
-    ROBOTS_TXT_FILENAME: str = 'robots.txt'
-    FAVICON_FILENAME: str = 'favicon.ico'
-    
-    STATICFILE_EXTENSIONSSTATICFILE_EXTENSIONS: frozenset[str] = frozenset((
-        # 99.999% of the time, URLs ending in these extensions are static files
-        # that can be downloaded as-is, not html pages that need to be rendered
-        'gif', 'jpeg', 'jpg', 'png', 'tif', 'tiff', 'wbmp', 'ico', 'jng', 'bmp',
-        'svg', 'svgz', 'webp', 'ps', 'eps', 'ai',
-        'mp3', 'mp4', 'm4a', 'mpeg', 'mpg', 'mkv', 'mov', 'webm', 'm4v',
-        'flv', 'wmv', 'avi', 'ogg', 'ts', 'm3u8',
-        'pdf', 'txt', 'rtf', 'rtfd', 'doc', 'docx', 'ppt', 'pptx', 'xls', 'xlsx',
-        'atom', 'rss', 'css', 'js', 'json',
-        'dmg', 'iso', 'img',
-        'rar', 'war', 'hqx', 'zip', 'gz', 'bz2', '7z',
 
-        # Less common extensions to consider adding later
-        # jar, swf, bin, com, exe, dll, deb
-        # ear, hqx, eot, wmlc, kml, kmz, cco, jardiff, jnlp, run, msi, msp, msm,
-        # pl pm, prc pdb, rar, rpm, sea, sit, tcl tk, der, pem, crt, xpi, xspf,
-        # ra, mng, asx, asf, 3gpp, 3gp, mid, midi, kar, jad, wml, htc, mml
+VERSION: str                              = archivebox.VERSION
 
-        # These are always treated as pages, not as static files, never add them:
-        # html, htm, shtml, xhtml, xml, aspx, php, cgi
-    ))
+TIMEZONE: str = 'UTC'
+DEFAULT_CLI_COLORS: Dict[str, str]        = DEFAULT_CLI_COLORS
+DISABLED_CLI_COLORS: Dict[str, str]       = benedict({k: '' for k in DEFAULT_CLI_COLORS})
+
+PACKAGE_DIR: Path                   = archivebox.PACKAGE_DIR
+PACKAGE_DIR_NAME: str               = archivebox.PACKAGE_DIR.name
+TEMPLATES_DIR_NAME: str             = 'templates'
+TEMPLATES_DIR: Path                 = archivebox.PACKAGE_DIR / TEMPLATES_DIR_NAME
+STATIC_DIR: Path                    = TEMPLATES_DIR / 'static'
+USER_PLUGINS_DIR_NAME: str          = 'user_plugins'
+CUSTOM_TEMPLATES_DIR_NAME: str      = 'user_templates'
+
+ARCHIVE_DIR_NAME: str = 'archive'
+SOURCES_DIR_NAME: str = 'sources'
+PERSONAS_DIR_NAME: str = 'personas'
+CRONTABS_DIR_NAME: str = 'crontabs'
+CACHE_DIR_NAME: str = 'cache'
+LOGS_DIR_NAME: str = 'logs'
+LIB_DIR_NAME: str = 'lib'
+TMP_DIR_NAME: str = 'tmp'
+OUTPUT_DIR: Path                    = archivebox.DATA_DIR
+ARCHIVE_DIR: Path                   = archivebox.DATA_DIR / ARCHIVE_DIR_NAME
+SOURCES_DIR: Path                   = archivebox.DATA_DIR / SOURCES_DIR_NAME
+PERSONAS_DIR: Path                  = archivebox.DATA_DIR / PERSONAS_DIR_NAME
+CACHE_DIR: Path                     = archivebox.DATA_DIR / CACHE_DIR_NAME
+LOGS_DIR: Path                      = archivebox.DATA_DIR / LOGS_DIR_NAME
+LIB_DIR: Path                       = archivebox.DATA_DIR / LIB_DIR_NAME
+TMP_DIR: Path                       = archivebox.DATA_DIR / TMP_DIR_NAME
+CUSTOM_TEMPLATES_DIR: Path          = archivebox.DATA_DIR / CUSTOM_TEMPLATES_DIR_NAME
+USER_PLUGINS_DIR: Path              = archivebox.DATA_DIR / USER_PLUGINS_DIR_NAME
+
+LIB_PIP_DIR: Path                   = LIB_DIR / 'pip'
+LIB_NPM_DIR: Path                   = LIB_DIR / 'npm'
+LIB_BROWSERS_DIR: Path              = LIB_DIR / 'browsers'
+LIB_BIN_DIR: Path                   = LIB_DIR / 'bin'
+BIN_DIR: Path                       = LIB_BIN_DIR
+
+CONFIG_FILENAME: str = 'ArchiveBox.conf'
+SQL_INDEX_FILENAME: str = 'index.sqlite3'
+
+CONFIG_FILE: Path                   = archivebox.DATA_DIR / CONFIG_FILENAME
+DATABASE_FILE: Path                 = archivebox.DATA_DIR / SQL_INDEX_FILENAME
+QUEUE_DATABASE_FILE: Path           = archivebox.DATA_DIR / SQL_INDEX_FILENAME.replace('index.', 'queue.')
+
+JSON_INDEX_FILENAME: str = 'index.json'
+HTML_INDEX_FILENAME: str = 'index.html'
+ROBOTS_TXT_FILENAME: str = 'robots.txt'
+FAVICON_FILENAME: str = 'favicon.ico'
+
+ALLOWDENYLIST_REGEX_FLAGS: int = re.IGNORECASE | re.UNICODE | re.MULTILINE
+
+STATICFILE_EXTENSIONS: frozenset[str] = frozenset((
+    # 99.999% of the time, URLs ending in these extensions are static files
+    # that can be downloaded as-is, not html pages that need to be rendered
+    'gif', 'jpeg', 'jpg', 'png', 'tif', 'tiff', 'wbmp', 'ico', 'jng', 'bmp',
+    'svg', 'svgz', 'webp', 'ps', 'eps', 'ai',
+    'mp3', 'mp4', 'm4a', 'mpeg', 'mpg', 'mkv', 'mov', 'webm', 'm4v',
+    'flv', 'wmv', 'avi', 'ogg', 'ts', 'm3u8',
+    'pdf', 'txt', 'rtf', 'rtfd', 'doc', 'docx', 'ppt', 'pptx', 'xls', 'xlsx',
+    'atom', 'rss', 'css', 'js', 'json',
+    'dmg', 'iso', 'img',
+    'rar', 'war', 'hqx', 'zip', 'gz', 'bz2', '7z',
+
+    # Less common extensions to consider adding later
+    # jar, swf, bin, com, exe, dll, deb
+    # ear, hqx, eot, wmlc, kml, kmz, cco, jardiff, jnlp, run, msi, msp, msm,
+    # pl pm, prc pdb, rar, rpm, sea, sit, tcl tk, der, pem, crt, xpi, xspf,
+    # ra, mng, asx, asf, 3gpp, 3gp, mid, midi, kar, jad, wml, htc, mml
+
+    # These are always treated as pages, not as static files, never add them:
+    # html, htm, shtml, xhtml, xml, aspx, php, cgi
+))
+
+INGORED_PATHS: frozenset[str] = frozenset((
+    ".git",
+    ".svn",
+    ".DS_Store",
+    ".gitignore",
+    "lost+found",
+    ".DS_Store",
+    ".env",
+    "Dockerfile",
+))
+PIP_RELATED_NAMES: frozenset[str] = frozenset((
+    ".venv",
+    "venv",
+    "virtualenv",
+    ".virtualenv",
+))
+NPM_RELATED_NAMES: frozenset[str] = frozenset((
+    "node_modules",
+    "package.json",
+    "package-lock.json",
+    "yarn.lock",
+))
+
+DATA_DIR_NAMES: frozenset[str] = frozenset((
+    ARCHIVE_DIR_NAME,
+    SOURCES_DIR_NAME,
+    LOGS_DIR_NAME,
+    CACHE_DIR_NAME,
+    LIB_DIR_NAME,
+    PERSONAS_DIR_NAME,
+    CUSTOM_TEMPLATES_DIR_NAME,
+    USER_PLUGINS_DIR_NAME,
+))
+DATA_DIRS: frozenset[Path] = frozenset(archivebox.DATA_DIR / dirname for dirname in DATA_DIR_NAMES)
+DATA_FILE_NAMES: frozenset[str] = frozenset((
+    CONFIG_FILENAME,
+    SQL_INDEX_FILENAME,
+    f"{SQL_INDEX_FILENAME}-wal",
+    f"{SQL_INDEX_FILENAME}-shm",
+    "queue.sqlite3",
+    "queue.sqlite3-wal",
+    "queue.sqlite3-shm",
+    "search.sqlite3",
+    JSON_INDEX_FILENAME,
+    HTML_INDEX_FILENAME,
+    ROBOTS_TXT_FILENAME,
+    FAVICON_FILENAME,
+    CONFIG_FILENAME,
+    f"{CONFIG_FILENAME}.bak",
+    "static_index.json",
+))
+
+# When initializing archivebox in a new directory, we check to make sure the dir is
+# actually empty so that we dont clobber someone's home directory or desktop by accident.
+# These files are exceptions to the is_empty check when we're trying to init a new dir,
+# as they could be from a previous archivebox version, system artifacts, dependencies, etc.
+ALLOWED_IN_OUTPUT_DIR: frozenset[str] = frozenset((
+    *INGORED_PATHS,
+    *PIP_RELATED_NAMES,
+    *NPM_RELATED_NAMES,
+    *DATA_DIR_NAMES,
+    *DATA_FILE_NAMES,
+    "static",                # created by old static exports <v0.6.0
+    "sonic",                 # created by docker bind mount
+))
+
+CODE_LOCATIONS = benedict({
+    'PACKAGE_DIR': {
+        'path': (archivebox.PACKAGE_DIR).resolve(),
+        'enabled': True,
+        'is_valid': (archivebox.PACKAGE_DIR / '__main__.py').exists(),
+    },
+    'LIB_DIR': {
+        'path': LIB_DIR.resolve(),
+        'enabled': True,
+        'is_valid': LIB_DIR.is_dir(),
+    },
+    'RUNTIME_CONFIG': {
+        'path': TMP_DIR.resolve(),
+        'enabled': True,
+        'is_valid': TMP_DIR.is_dir(),
+    },
+    'TEMPLATES_DIR': {
+        'path': TEMPLATES_DIR.resolve(),
+        'enabled': True,
+        'is_valid': STATIC_DIR.exists(),
+    },
+    'CUSTOM_TEMPLATES_DIR': {
+        'path': CUSTOM_TEMPLATES_DIR.resolve(),
+        'enabled': True,
+        'is_valid': CUSTOM_TEMPLATES_DIR.is_dir(),
+    },
+})
     
-    INGORED_PATHS: frozenset[str] = frozenset((
-        ".git",
-        ".svn",
-        ".DS_Store",
-        ".gitignore",
-        "lost+found",
-        ".DS_Store",
-        ".env",
-        "Dockerfile",
-    ))
-    PIP_RELATED_NAMES: frozenset[str] = frozenset((
-        ".venv",
-        "venv",
-        "virtualenv",
-        ".virtualenv",
-    ))
-    NPM_RELATED_NAMES: frozenset[str] = frozenset((
-        "node_modules",
-        "package.json",
-        "package-lock.json",
-        "yarn.lock",
-    ))
-    
-    DATA_DIR_NAMES: frozenset[str] = frozenset((
-        ARCHIVE_DIR_NAME,
-        SOURCES_DIR_NAME,
-        LOGS_DIR_NAME,
-        CACHE_DIR_NAME,
-        LIB_DIR_NAME,
-        PERSONAS_DIR_NAME,
-        CUSTOM_TEMPLATES_DIR_NAME,
-        USER_PLUGINS_DIR_NAME,
-    ))
-    DATA_DIRS: frozenset[Path] = frozenset(archivebox.DATA_DIR / dirname for dirname in DATA_DIR_NAMES)
-    DATA_FILE_NAMES: frozenset[str] = frozenset((
-        CONFIG_FILENAME,
-        SQL_INDEX_FILENAME,
-        f"{SQL_INDEX_FILENAME}-wal",
-        f"{SQL_INDEX_FILENAME}-shm",
-        "queue.sqlite3",
-        "queue.sqlite3-wal",
-        "queue.sqlite3-shm",
-        "search.sqlite3",
-        JSON_INDEX_FILENAME,
-        HTML_INDEX_FILENAME,
-        ROBOTS_TXT_FILENAME,
-        FAVICON_FILENAME,
-        CONFIG_FILENAME,
-        f"{CONFIG_FILENAME}.bak",
-        "static_index.json",
-    ))
-    
-    # When initializing archivebox in a new directory, we check to make sure the dir is
-    # actually empty so that we dont clobber someone's home directory or desktop by accident.
-    # These files are exceptions to the is_empty check when we're trying to init a new dir,
-    # as they could be from a previous archivebox version, system artifacts, dependencies, etc.
-    ALLOWED_IN_OUTPUT_DIR: frozenset[str] = frozenset((
-        *INGORED_PATHS,
-        *PIP_RELATED_NAMES,
-        *NPM_RELATED_NAMES,
-        *DATA_DIR_NAMES,
-        *DATA_FILE_NAMES,
-        "static",                # created by old static exports <v0.6.0
-        "sonic",                 # created by docker bind mount
-    ))
-    
-    CODE_LOCATIONS = MappingProxyType(benedict({
-        'PACKAGE_DIR': {
-            'path': (archivebox.PACKAGE_DIR).resolve(),
-            'enabled': True,
-            'is_valid': (archivebox.PACKAGE_DIR / '__main__.py').exists(),
-        },
-        'LIB_DIR': {
-            'path': LIB_DIR.resolve(),
-            'enabled': True,
-            'is_valid': LIB_DIR.is_dir(),
-        },
-        'RUNTIME_CONFIG': {
-            'path': TMP_DIR.resolve(),
-            'enabled': True,
-            'is_valid': TMP_DIR.is_dir(),
-        },
-        'TEMPLATES_DIR': {
-            'path': TEMPLATES_DIR.resolve(),
-            'enabled': True,
-            'is_valid': STATIC_DIR.exists(),
-        },
-        'CUSTOM_TEMPLATES_DIR': {
-            'path': CUSTOM_TEMPLATES_DIR.resolve(),
-            'enabled': True,
-            'is_valid': CUSTOM_TEMPLATES_DIR.is_dir(),
-        },
-    }))
-        
-    DATA_LOCATIONS = MappingProxyType(benedict({
-        "OUTPUT_DIR": {
-            "path": archivebox.DATA_DIR.resolve(),
-            "enabled": True,
-            "is_valid": DATABASE_FILE.exists(),
-            "is_mount": os.path.ismount(archivebox.DATA_DIR.resolve()),
-        },
-        "CONFIG_FILE": {
-            "path": CONFIG_FILE.resolve(),
-            "enabled": True,
-            "is_valid": CONFIG_FILE.exists(),
-        },
-        "SQL_INDEX": {
-            "path": DATABASE_FILE.resolve(),
-            "enabled": True,
-            "is_valid": DATABASE_FILE.exists(),
-            "is_mount": os.path.ismount(DATABASE_FILE.resolve()),
-        },
-        "QUEUE_DATABASE": {
-            "path": QUEUE_DATABASE_FILE.resolve(),
-            "enabled": True,
-            "is_valid": QUEUE_DATABASE_FILE.exists(),
-            "is_mount": os.path.ismount(QUEUE_DATABASE_FILE.resolve()),
-        },
-        "ARCHIVE_DIR": {
-            "path": ARCHIVE_DIR.resolve(),
-            "enabled": True,
-            "is_valid": ARCHIVE_DIR.exists(),
-            "is_mount": os.path.ismount(ARCHIVE_DIR.resolve()),
-        },
-        "SOURCES_DIR": {
-            "path": SOURCES_DIR.resolve(),
-            "enabled": True,
-            "is_valid": SOURCES_DIR.exists(),
-        },
-        "PERSONAS_DIR": {
-            "path": PERSONAS_DIR.resolve(),
-            "enabled": PERSONAS_DIR.exists(),
-            "is_valid": PERSONAS_DIR.exists(),
-        },
-        "LOGS_DIR": {
-            "path": LOGS_DIR.resolve(),
-            "enabled": True,
-            "is_valid": LOGS_DIR.is_dir(),
-        },
-        "CACHE_DIR": {
-            "path": CACHE_DIR.resolve(),
-            "enabled": True,
-            "is_valid": CACHE_DIR.is_dir(),
-        },
-    }))
-    
-    def items(self):
-        return self._asdict().items()
-    
-    def keys(self):
-        return self._asdict().keys()
-    
-    def values(self):
-        return self._asdict().values()
+DATA_LOCATIONS = benedict({
+    "OUTPUT_DIR": {
+        "path": archivebox.DATA_DIR.resolve(),
+        "enabled": True,
+        "is_valid": DATABASE_FILE.exists(),
+        "is_mount": os.path.ismount(archivebox.DATA_DIR.resolve()),
+    },
+    "CONFIG_FILE": {
+        "path": CONFIG_FILE.resolve(),
+        "enabled": True,
+        "is_valid": CONFIG_FILE.exists(),
+    },
+    "SQL_INDEX": {
+        "path": DATABASE_FILE.resolve(),
+        "enabled": True,
+        "is_valid": DATABASE_FILE.exists(),
+        "is_mount": os.path.ismount(DATABASE_FILE.resolve()),
+    },
+    "QUEUE_DATABASE": {
+        "path": QUEUE_DATABASE_FILE.resolve(),
+        "enabled": True,
+        "is_valid": QUEUE_DATABASE_FILE.exists(),
+        "is_mount": os.path.ismount(QUEUE_DATABASE_FILE.resolve()),
+    },
+    "ARCHIVE_DIR": {
+        "path": ARCHIVE_DIR.resolve(),
+        "enabled": True,
+        "is_valid": ARCHIVE_DIR.exists(),
+        "is_mount": os.path.ismount(ARCHIVE_DIR.resolve()),
+    },
+    "SOURCES_DIR": {
+        "path": SOURCES_DIR.resolve(),
+        "enabled": True,
+        "is_valid": SOURCES_DIR.exists(),
+    },
+    "PERSONAS_DIR": {
+        "path": PERSONAS_DIR.resolve(),
+        "enabled": PERSONAS_DIR.exists(),
+        "is_valid": PERSONAS_DIR.exists(),
+    },
+    "LOGS_DIR": {
+        "path": LOGS_DIR.resolve(),
+        "enabled": True,
+        "is_valid": LOGS_DIR.is_dir(),
+    },
+    "CACHE_DIR": {
+        "path": CACHE_DIR.resolve(),
+        "enabled": True,
+        "is_valid": CACHE_DIR.is_dir(),
+    },
+})
 
 
-CONSTANTS = ConstantsConfig()
+
+CONSTANTS = benedict({key: value for key, value in globals().items() if key.isupper()})
 CONSTANTS_CONFIG = CONSTANTS